From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D59C04FF3 for ; Mon, 24 May 2021 16:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00BA4613BF for ; Mon, 24 May 2021 16:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233169AbhEXQWw (ORCPT ); Mon, 24 May 2021 12:22:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37117 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233026AbhEXQWv (ORCPT ); Mon, 24 May 2021 12:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621873283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbtJz1B6PVgjPOA+u4nJ3svJYu5vKUQ2E1CuhCFrHNU=; b=Tt6uU5uWRLtOONWd2edfp9+uKh92N8i2q9tj9l5giQpOfCiQulTpp0Jyf0oE5v+kjhQTNU rsHfPGOGix37M1HOT89BaAqfL7+C823Y19TmBQ1xFTSZqH9HQNCoXpzDPNDVEBvy0pnsaS HWcj6ipw49DmKplFQspHRmnwdUesdms= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-TfRRGs56PEKah8kswuFbag-1; Mon, 24 May 2021 12:21:21 -0400 X-MC-Unique: TfRRGs56PEKah8kswuFbag-1 Received: by mail-ed1-f70.google.com with SMTP id da10-20020a056402176ab029038f0fea1f51so7648482edb.13 for ; Mon, 24 May 2021 09:21:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vbtJz1B6PVgjPOA+u4nJ3svJYu5vKUQ2E1CuhCFrHNU=; b=ofyeyNKYbxTZK0BqoHhYk6u8Ube6jgFExQxj3IBWBMxxkGejrS5tczZLKmPhw4oSYo 4Czi0WiEUOm718wdwoHE4aszISx5jb34v4hK1loDrGh0PP0/ajyRJezWmvPHlZjy8glT 2RfR6bdwDRLtXAUBWw9cl9ZczRn+NMenrk0OXBk0B+GVMBcReLIqZd3p48a6ZbkIXp+C YDCvdxDzdBcpNyoM9Ez+yk+dISY+TDXalmK9Zj9SCjPYbrQwQjRFVHaNc4Gd83cwifSD 7RWUVqGRGPLxepYzqt1ekcqiUmtF7TWdWg0y2u4MOfROSrDXLqb4sdP9frWf8VjFlp9y QsAg== X-Gm-Message-State: AOAM532K+4Q/d1g1DDHRoB312dh+ZetKdqrtqqaTEBZ/gNENOUGV3hxM ytzJFOUw/fs9wYYgi8IXfuZW9+4GkK0svgFWfk5R2vTNHgkWswMJUl23l/uOWtlgMsWVIEF3csF 4EODmRu/PWdnR X-Received: by 2002:a50:fd17:: with SMTP id i23mr27592045eds.54.1621873279597; Mon, 24 May 2021 09:21:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm863y5lfpQdNIOD2nZa7MOniCUm6EVbqV7tFHhyQ18EZCIeYhCuz7nIN2OybL6GU1wN8IIQ== X-Received: by 2002:a50:fd17:: with SMTP id i23mr27591992eds.54.1621873279146; Mon, 24 May 2021 09:21:19 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id w3sm2879892eds.78.2021.05.24.09.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 09:21:18 -0700 (PDT) Subject: Re: [PATCH v2 5/5] KVM: x86: hyper-v: Deactivate APICv only when AutoEOI feature is in use To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Maxim Levitsky , Kechen Lu , linux-kernel@vger.kernel.org References: <20210518144339.1987982-1-vkuznets@redhat.com> <20210518144339.1987982-6-vkuznets@redhat.com> From: Paolo Bonzini Message-ID: <82e2a6a0-337a-4b92-2271-493344a38960@redhat.com> Date: Mon, 24 May 2021 18:21:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210518144339.1987982-6-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 18/05/21 16:43, Vitaly Kuznetsov wrote: > APICV_INHIBIT_REASON_HYPERV is currently unconditionally forced upon > SynIC activation as SynIC's AutoEOI is incompatible with APICv/AVIC. It is, > however, possible to track whether the feature was actually used by the > guest and only inhibit APICv/AVIC when needed. > > TLFS suggests a dedicated 'HV_DEPRECATING_AEOI_RECOMMENDED' flag to let > Windows know that AutoEOI feature should be avoided. While it's up to > KVM userspace to set the flag, KVM can help a bit by exposing global > APICv/AVIC enablement: in case APICv/AVIC usage is impossible, AutoEOI > is still preferred. > > Signed-off-by: Vitaly Kuznetsov Should it also disable APICv unconditionally if HV_DEPRECATING_AEOI_RECOMMENDED is not in the guest CPUID? That should avoid ping-pong between enabled and disabled APICv even in pathological cases that we cannot think about. Paolo > --- > arch/x86/include/asm/kvm_host.h | 3 +++ > arch/x86/kvm/hyperv.c | 27 +++++++++++++++++++++------ > 2 files changed, 24 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index bf5807d35339..5e03ab4c0e4f 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -936,6 +936,9 @@ struct kvm_hv { > /* How many vCPUs have VP index != vCPU index */ > atomic_t num_mismatched_vp_indexes; > > + /* How many SynICs use 'AutoEOI' feature */ > + atomic_t synic_auto_eoi_used; > + > struct hv_partition_assist_pg *hv_pa_pg; > struct kvm_hv_syndbg hv_syndbg; > }; > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index f98370a39936..89e7d5b99279 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -87,6 +87,10 @@ static bool synic_has_vector_auto_eoi(struct kvm_vcpu_hv_synic *synic, > static void synic_update_vector(struct kvm_vcpu_hv_synic *synic, > int vector) > { > + struct kvm_vcpu *vcpu = hv_synic_to_vcpu(synic); > + struct kvm_hv *hv = to_kvm_hv(vcpu->kvm); > + int auto_eoi_old, auto_eoi_new; > + > if (vector < HV_SYNIC_FIRST_VALID_VECTOR) > return; > > @@ -95,10 +99,25 @@ static void synic_update_vector(struct kvm_vcpu_hv_synic *synic, > else > __clear_bit(vector, synic->vec_bitmap); > > + auto_eoi_old = bitmap_weight(synic->auto_eoi_bitmap, 256); > + > if (synic_has_vector_auto_eoi(synic, vector)) > __set_bit(vector, synic->auto_eoi_bitmap); > else > __clear_bit(vector, synic->auto_eoi_bitmap); > + > + auto_eoi_new = bitmap_weight(synic->auto_eoi_bitmap, 256); > + > + /* Hyper-V SynIC auto EOI SINTs are not compatible with APICV */ > + if (!auto_eoi_old && auto_eoi_new) { > + if (atomic_inc_return(&hv->synic_auto_eoi_used) == 1) > + kvm_request_apicv_update(vcpu->kvm, false, > + APICV_INHIBIT_REASON_HYPERV); > + } else if (!auto_eoi_new && auto_eoi_old) { > + if (atomic_dec_return(&hv->synic_auto_eoi_used) == 0) > + kvm_request_apicv_update(vcpu->kvm, true, > + APICV_INHIBIT_REASON_HYPERV); > + } > } > > static int synic_set_sint(struct kvm_vcpu_hv_synic *synic, int sint, > @@ -931,12 +950,6 @@ int kvm_hv_activate_synic(struct kvm_vcpu *vcpu, bool dont_zero_synic_pages) > > synic = to_hv_synic(vcpu); > > - /* > - * Hyper-V SynIC auto EOI SINT's are > - * not compatible with APICV, so request > - * to deactivate APICV permanently. > - */ > - kvm_request_apicv_update(vcpu->kvm, false, APICV_INHIBIT_REASON_HYPERV); > synic->active = true; > synic->dont_zero_synic_pages = dont_zero_synic_pages; > synic->control = HV_SYNIC_CONTROL_ENABLE; > @@ -2198,6 +2211,8 @@ int kvm_get_hv_cpuid(struct kvm_vcpu *vcpu, struct kvm_cpuid2 *cpuid, > ent->eax |= HV_X64_ENLIGHTENED_VMCS_RECOMMENDED; > if (!cpu_smt_possible()) > ent->eax |= HV_X64_NO_NONARCH_CORESHARING; > + if (enable_apicv) > + ent->eax |= HV_DEPRECATING_AEOI_RECOMMENDED; > /* > * Default number of spinlock retry attempts, matches > * HyperV 2016. >