From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org,
Richard Henderson <richard.henderson@linaro.org>,
Aurelien Jarno <aurelien@aurel32.net>,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH 00/17] target/mips: Convert MSA ASE to decodetree
Date: Wed, 9 Dec 2020 12:07:56 +0800 [thread overview]
Message-ID: <84a9e6e1-8606-777d-2204-63effb649184@flygoat.com> (raw)
In-Reply-To: <20201208003702.4088927-1-f4bug@amsat.org>
在 2020/12/8 上午8:36, Philippe Mathieu-Daudé 写道:
> Finally, we use decodetree with the MIPS target.
>
> Starting easy with the MSA ASE. 2700+ lines extracted
> from helper.h and translate.c, now built as an new
> object: mod-msa_translate.o.
>
> While the diff stat is positive by 86 lines, we actually
> (re)moved code, but added (C) notices.
>
> The most interesting patches are the 2 last ones.
>
> Please review,
>
> Phil.
>
> Based-on: <20201207224335.4030582-1-f4bug@amsat.org>
> (linux-user: Rework get_elf_hwcap() and support MIPS Loongson 2F/3A)
> Based-on: <20201207235539.4070364-1-f4bug@amsat.org>
> (target/mips: Add translate.h and fpu_translate.h headers)
Great work!
For the whole series:
Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>
> Philippe Mathieu-Daudé (17):
> target/mips: Introduce ase_msa_available() helper
> target/mips: Simplify msa_reset()
> target/mips: Use CP0_Config3 to set MIPS_HFLAG_MSA
> target/mips: Simplify MSA TCG logic
> target/mips: Remove now unused ASE_MSA definition
> target/mips: Alias MSA vector registers on FPU scalar registers
> target/mips: Extract msa_translate_init() from mips_tcg_init()
> target/mips: Remove CPUMIPSState* argument from gen_msa*() methods
> target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ()
> target/mips: Rename msa_helper.c as mod-msa_helper.c
> target/mips: Move msa_reset() to mod-msa_helper.c
> target/mips: Extract MSA helpers from op_helper.c
> target/mips: Extract MSA helper definitions
> target/mips: Declare gen_msa/_branch() in 'translate.h'
> target/mips: Extract MSA translation routines
> target/mips: Introduce decode tree bindings for MSA opcodes
> target/mips: Use decode_msa32() generated from decodetree
>
> target/mips/cpu.h | 6 +
> target/mips/fpu_translate.h | 10 -
> target/mips/helper.h | 436 +---
> target/mips/internal.h | 4 +-
> target/mips/mips-defs.h | 1 -
> target/mips/translate.h | 4 +
> target/mips/mod-msa32.decode | 24 +
> target/mips/kvm.c | 12 +-
> .../mips/{msa_helper.c => mod-msa_helper.c} | 429 ++++
> target/mips/mod-msa_translate.c | 2270 +++++++++++++++++
> target/mips/op_helper.c | 394 ---
> target/mips/translate.c | 2264 +---------------
> target/mips/meson.build | 9 +-
> target/mips/mod-msa_helper.h.inc | 443 ++++
> target/mips/translate_init.c.inc | 38 +-
> 15 files changed, 3215 insertions(+), 3129 deletions(-)
> create mode 100644 target/mips/mod-msa32.decode
> rename target/mips/{msa_helper.c => mod-msa_helper.c} (93%)
> create mode 100644 target/mips/mod-msa_translate.c
> create mode 100644 target/mips/mod-msa_helper.h.inc
>
prev parent reply other threads:[~2020-12-09 4:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 0:36 [PATCH 00/17] target/mips: Convert MSA ASE to decodetree Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 01/17] target/mips: Introduce ase_msa_available() helper Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 02/17] target/mips: Simplify msa_reset() Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 03/17] target/mips: Use CP0_Config3 to set MIPS_HFLAG_MSA Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 04/17] target/mips: Simplify MSA TCG logic Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 05/17] target/mips: Remove now unused ASE_MSA definition Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 06/17] target/mips: Alias MSA vector registers on FPU scalar registers Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 07/17] target/mips: Extract msa_translate_init() from mips_tcg_init() Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 08/17] target/mips: Remove CPUMIPSState* argument from gen_msa*() methods Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 09/17] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ() Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 10/17] target/mips: Rename msa_helper.c as mod-msa_helper.c Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 11/17] target/mips: Move msa_reset() to mod-msa_helper.c Philippe Mathieu-Daudé
2020-12-08 23:55 ` Richard Henderson
2020-12-08 0:36 ` [PATCH 12/17] target/mips: Extract MSA helpers from op_helper.c Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 13/17] target/mips: Extract MSA helper definitions Philippe Mathieu-Daudé
2020-12-08 0:36 ` [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h' Philippe Mathieu-Daudé
2020-12-08 23:56 ` Richard Henderson
2020-12-09 0:01 ` Richard Henderson
2020-12-09 0:03 ` Richard Henderson
2020-12-09 9:17 ` Philippe Mathieu-Daudé
2020-12-09 15:25 ` Richard Henderson
2020-12-08 0:37 ` [PATCH 16/17] target/mips: Introduce decode tree bindings for MSA opcodes Philippe Mathieu-Daudé
2020-12-09 0:05 ` Richard Henderson
2020-12-09 4:09 ` Jiaxun Yang
2020-12-08 0:37 ` [PATCH 17/17] target/mips: Use decode_msa32() generated from decodetree Philippe Mathieu-Daudé
2020-12-09 0:06 ` Richard Henderson
2020-12-08 0:39 ` [PATCH 00/17] target/mips: Convert MSA ASE to decodetree Philippe Mathieu-Daudé
2020-12-08 16:30 ` Philippe Mathieu-Daudé
2020-12-09 4:07 ` Jiaxun Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84a9e6e1-8606-777d-2204-63effb649184@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).