From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212D2C43462 for ; Mon, 10 May 2021 07:40:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6AC16144F for ; Mon, 10 May 2021 07:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbhEJHlH (ORCPT ); Mon, 10 May 2021 03:41:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:49650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhEJHlG (ORCPT ); Mon, 10 May 2021 03:41:06 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 761426128E; Mon, 10 May 2021 07:40:02 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lg0WG-000JiN-9o; Mon, 10 May 2021 08:40:00 +0100 Date: Mon, 10 May 2021 08:39:59 +0100 Message-ID: <8735uvox4g.wl-maz@kernel.org> From: Marc Zyngier To: Shaokun Zhang Cc: Zhu Lingshan , , , , , , , , Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" In-Reply-To: References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: zhangshaokun@hisilicon.com, lingshan.zhu@intel.com, jasowang@redhat.com, mst@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 10 May 2021 02:12:22 +0100, Shaokun Zhang wrote: > > Hi Marc, > > On 2021/5/8 17:29, Marc Zyngier wrote: > > On Sat, 08 May 2021 08:11:52 +0100, > > Zhu Lingshan wrote: > >> > >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. > >> > >> The reverted commit may cause VM freeze on arm64 platform. > >> Because on arm64 platform, stop a consumer will suspend the VM, > >> the VM will freeze without a start consumer > > > > It also unconditionally calls del_consumer on the producer, which > > isn't exactly expected. > > > >> > >> Signed-off-by: Zhu Lingshan > > > > Reported-by: Shaokun Zhang > > Thanks for the tag, it works with this patch, So: > Tested-by: Shaokun Zhang > > I shall invite you to have a drink for the quick debug. > Anyway, thank you again. No worries, glad we were able to root-cause the problem quickly enough. Thanks, M. -- Without deviation from the norm, progress is not possible.