From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Fam Zheng" <fam@euphon.net>,
"Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-block@nongnu.org, kvm@vger.kernel.org,
"Laurent Vivier" <lvivier@redhat.com>,
qemu-arm@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"John Snow" <jsnow@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v6 06/11] target/arm: Restrict ARMv7 R-profile cpus to TCG accel
Date: Mon, 01 Feb 2021 17:37:22 +0000 [thread overview]
Message-ID: <874kivvgcv.fsf@linaro.org> (raw)
In-Reply-To: <80af7db7-2311-7cc5-93a0-f0609b0222d0@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
>> KVM requires the target cpu to be at least ARMv8 architecture
>> (support on ARMv7 has been dropped in commit 82bf7ae84ce:
>> "target/arm: Remove KVM support for 32-bit Arm hosts").
>>
>> Beside, KVM only supports A-profile, thus won't be able to run
>> R-profile cpus.
>>
>> Only enable the following ARMv7 R-Profile CPUs when TCG is available:
>>
>> - Cortex-R5
>> - Cortex-R5F
>>
>> The following machine is no more built when TCG is disabled:
>>
>> - xlnx-zcu102 Xilinx ZynqMP ZCU102 board with 4xA53s and 2xR5Fs
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> default-configs/devices/aarch64-softmmu.mak | 1 -
>> hw/arm/Kconfig | 2 ++
>> target/arm/Kconfig | 4 ++++
>> 3 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/devices/aarch64-softmmu.mak b/default-configs/devices/aarch64-softmmu.mak
>> index 958b1e08e40..a4202f56817 100644
>> --- a/default-configs/devices/aarch64-softmmu.mak
>> +++ b/default-configs/devices/aarch64-softmmu.mak
>> @@ -3,6 +3,5 @@
>> # We support all the 32 bit boards so need all their config
>> include arm-softmmu.mak
>>
>> -CONFIG_XLNX_ZYNQMP_ARM=y
>> CONFIG_XLNX_VERSAL=y
>> CONFIG_SBSA_REF=y
>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
>> index 6c4bce4d637..4baf1f97694 100644
>> --- a/hw/arm/Kconfig
>> +++ b/hw/arm/Kconfig
>> @@ -360,8 +360,10 @@ config STM32F405_SOC
>>
>> config XLNX_ZYNQMP_ARM
>> bool
>> + default y if TCG && ARM
>
> The correct line is:
>
> "default y if TCG && AARCH64"
Ahh yes, TIL we had some R-profile cores in QEMU ;-)
with the fix:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2021-02-01 17:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131115022.242570-1-f4bug@amsat.org>
[not found] ` <20210131115022.242570-6-f4bug@amsat.org>
2021-01-31 14:29 ` [PATCH v6 05/11] target/arm: Restrict ARMv6 cpus to TCG accel Claudio Fontana
2021-02-01 17:18 ` Alex Bennée
2021-01-31 14:40 ` [PATCH v6 00/11] Support disabling TCG on ARM (part 2) Claudio Fontana
2021-01-31 15:23 ` Philippe Mathieu-Daudé
[not found] ` <20210131115022.242570-2-f4bug@amsat.org>
[not found] ` <87d562ba-20e5-ee50-8793-59d77564f4da@suse.de>
2021-01-31 15:23 ` [PATCH v6 01/11] sysemu/tcg: Introduce tcg_builtin() helper Philippe Mathieu-Daudé
2021-02-01 14:29 ` Claudio Fontana
[not found] ` <20210131115022.242570-3-f4bug@amsat.org>
2021-02-01 13:24 ` [PATCH v6 02/11] exec: Restrict TCG specific headers Alex Bennée
[not found] ` <20210131115022.242570-7-f4bug@amsat.org>
[not found] ` <80af7db7-2311-7cc5-93a0-f0609b0222d0@redhat.com>
2021-02-01 17:37 ` Alex Bennée [this message]
[not found] ` <20210131115022.242570-4-f4bug@amsat.org>
2021-02-01 17:10 ` [PATCH v6 03/11] target/arm: Restrict ARMv4 cpus to TCG accel Alex Bennée
2021-03-04 11:55 ` Claudio Fontana
2021-03-04 19:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kivvgcv.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).