From: Florian Weimer <fweimer@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Sean Christopherson <seanjc@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: tools/testing/selftests/kvm/rseq_test and glibc 2.35
Date: Tue, 09 Aug 2022 08:18:54 +0200 [thread overview]
Message-ID: <877d3indm9.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <465d3599-2433-7f6e-66fc-b4018ba258cf@redhat.com> (Gavin Shan's message of "Tue, 9 Aug 2022 11:47:43 +1000")
* Gavin Shan:
> Hi Florian,
>
> On 8/9/22 2:01 AM, Florian Weimer wrote:
>> It has come to my attention that the KVM rseq test apparently needs to
>> be ported to glibc 2.35. The background is that on aarch64, rseq is the
>> only way to get a practically useful sched_getcpu. (There's no hidden
>> per-task CPU state the vDSO could reveal as the CPU ID.)
>>
>
> Yes, kvm/selftests/rseq needs to support glibc 2.35. The question is
> about glibc 2.34 or 2.35 because kvm/selftest/rseq fails on glibc 2.34
>
> I would guess upstream-glibc-2.35 feature is enabled on downstream
> glibc-2.34?
>
> # ./rseq_test
> ==== Test Assertion Failure ====
> rseq_test.c:60: !r
> pid=112043 tid=112043 errno=22 - Invalid argument
> 1 0x0000000000401973: main at rseq_test.c:226
> 2 0x0000ffff84b6c79b: ?? ??:0
> 3 0x0000ffff84b6c86b: ?? ??:0
> 4 0x0000000000401b6f: _start at ??:?
> rseq failed, errno = 22 (Invalid argument)
> # rpm -aq | grep glibc-2
> glibc-2.34-39.el9.aarch64
Yes, we have enabled it downstream.
glibc: Restartable sequences interfaces and sched_getcpu accelerated
by default
<https://bugzilla.redhat.com/show_bug.cgi?id=2085529>
However,
GLIBC_TUNABLES=glibc.pthread.rseq=0 ./rseq_test
should still work (we added the ability to disable rseq registration
precisely to enable scenarios like this), but tunables are an optional
glibc feature, so the upstream kernel should probably still be fixed.
> Mathieu and Florian, the fixes have been posted. It would be nice for you
> to review if you have free cycles :)
>
> https://lore.kernel.org/kvmarm/20220809060627.115847-1-gshan@redhat.com/T/#t
Excellent. I'm going to have a look.
Thanks,
Florian
prev parent reply other threads:[~2022-08-09 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 16:01 tools/testing/selftests/kvm/rseq_test and glibc 2.35 Florian Weimer
2022-08-09 1:47 ` Gavin Shan
2022-08-09 0:57 ` Mathieu Desnoyers
2022-08-09 3:58 ` Gavin Shan
2022-08-09 6:23 ` Gavin Shan
2022-08-09 6:18 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d3indm9.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).