From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC8EC433ED for ; Wed, 7 Apr 2021 15:31:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76CD96138B for ; Wed, 7 Apr 2021 15:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347315AbhDGPbY (ORCPT ); Wed, 7 Apr 2021 11:31:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:39408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234082AbhDGPbQ (ORCPT ); Wed, 7 Apr 2021 11:31:16 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC88961382; Wed, 7 Apr 2021 15:31:06 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lUA93-0066aw-3T; Wed, 07 Apr 2021 16:31:05 +0100 Date: Wed, 07 Apr 2021 16:31:04 +0100 Message-ID: <877dlep0w7.wl-maz@kernel.org> From: Marc Zyngier To: Richard Cochran Cc: pbonzini@redhat.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, seanjc@google.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, Andre.Przywara@arm.com, steven.price@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, jianyong.wu@arm.com, kernel-team@android.com Subject: Re: [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent In-Reply-To: <20210407151334.GB7379@hoboy.vegasvil.org> References: <20210330145430.996981-1-maz@kernel.org> <20210330145430.996981-4-maz@kernel.org> <87eefmpho3.wl-maz@kernel.org> <20210407151334.GB7379@hoboy.vegasvil.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: richardcochran@gmail.com, pbonzini@redhat.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, seanjc@google.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, Andre.Przywara@arm.com, steven.price@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, jianyong.wu@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 07 Apr 2021 16:13:34 +0100, Richard Cochran wrote: > > On Wed, Apr 07, 2021 at 10:28:44AM +0100, Marc Zyngier wrote: > > On Tue, 30 Mar 2021 15:54:26 +0100, > > Marc Zyngier wrote: > > > > > > From: Jianyong Wu > > > > > > Currently, the ptp_kvm module contains a lot of x86-specific code. > > > Let's move this code into a new arch-specific file in the same directory, > > > and rename the arch-independent file to ptp_kvm_common.c. > > > > > > Reviewed-by: Andre Przywara > > > Signed-off-by: Jianyong Wu > > > Signed-off-by: Marc Zyngier > > > Link: https://lore.kernel.org/r/20201209060932.212364-4-jianyong.wu@arm.com > > > > Richard, Paolo, > > > > Can I get an Ack on this and patch #7? We're getting pretty close to > > the next merge window, and this series has been going on for a couple > > of years now... > > For both patches: > > Acked-by: Richard Cochran Cheers Richard, much appreciated. M. -- Without deviation from the norm, progress is not possible.