From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C242C31E44 for ; Fri, 14 Jun 2019 10:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8034F208CA for ; Fri, 14 Jun 2019 10:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727415AbfFNKIF (ORCPT ); Fri, 14 Jun 2019 06:08:05 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52113 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfFNKIF (ORCPT ); Fri, 14 Jun 2019 06:08:05 -0400 Received: by mail-wm1-f66.google.com with SMTP id 207so1726872wma.1 for ; Fri, 14 Jun 2019 03:08:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rjUazryDHv7wuzJPfN35mvC+nqyi403EO56ab8UJ3vM=; b=YWKcLwXMOPhpBkHlGNdjv65f5kjoIPh0CTWGwzXhazLQd+BrdM4ZAmMm1e5lO89D4r wUoU4If2HBKuqRhdYDcyfNpFnd93397BQYyYWls9PwUKjc3QFibHg+9nt0iuRpG1fyzA QcTiL0YYy0ptrMvf2d2WrAL0yhkI291oK8mEPc/pNP8tYVtaQ66RJtiL5QAjY4+knO2X X7AkwSNBcK0E0xeV5QeiT77I9U02x3fFiT4KSdJVQnqdhbSDMESzA2RwsYi1me762Vfn V8jkfcQsbLxf1rwnlEnHqvwyTQSnl2Q1x/Z3NkksYL8cX78HUwGL2gZe8+JHPy/VSfs5 YzLw== X-Gm-Message-State: APjAAAUgpw05KEy3p3v8onsR5nWN9QoklD3MkzCHkv6nyOKLvjV3axfA mlmb63dYylkKnYFa9f8LZSoOXQ== X-Google-Smtp-Source: APXvYqzCWohsnjsTkpzB4opXNwIILIOK7t34ke5ERFVDtWha+QAnoaQQBbp73Yhj7uy5IC+qUKcSIQ== X-Received: by 2002:a1c:63d7:: with SMTP id x206mr7451274wmb.19.1560506882990; Fri, 14 Jun 2019 03:08:02 -0700 (PDT) Received: from vitty.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id t7sm1683230wrn.52.2019.06.14.03.08.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 03:08:02 -0700 (PDT) From: Vitaly Kuznetsov To: Peter Zijlstra Cc: Dmitry Safonov , linux-kernel@vger.kernel.org, Prasanna Panchamukhi , Andy Lutomirski , Borislav Petkov , Cathy Avery , Haiyang Zhang , "H. Peter Anvin" , Ingo Molnar , "K. Y. Srinivasan" , "Michael Kelley \(EOSG\)" , Mohammed Gamal , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Roman Kagan , Sasha Levin , Stephen Hemminger , Thomas Gleixner , devel@linuxdriverproject.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] x86/hyperv: Disable preemption while setting reenlightenment vector In-Reply-To: <20190614082807.GV3436@hirez.programming.kicks-ass.net> References: <20190611212003.26382-1-dima@arista.com> <8736kff6q3.fsf@vitty.brq.redhat.com> <20190614082807.GV3436@hirez.programming.kicks-ass.net> Date: Fri, 14 Jun 2019 12:08:01 +0200 Message-ID: <877e9o7a4e.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Peter Zijlstra writes: > @@ -182,7 +182,7 @@ void set_hv_tscchange_cb(void (*cb)(void)) > struct hv_reenlightenment_control re_ctrl = { > .vector = HYPERV_REENLIGHTENMENT_VECTOR, > .enabled = 1, > - .target_vp = hv_vp_index[smp_processor_id()] > + .target_vp = hv_vp_index[raw_smp_processor_id()] > }; > struct hv_tsc_emulation_control emu_ctrl = {.enabled = 1}; > Yes, this should do, thanks! I'd also suggest to leave a comment like /* * This function can get preemted and migrate to a different CPU * but this doesn't matter. We just need to assign * reenlightenment notification to some online CPU. In case this * CPU goes offline, hv_cpu_die() will re-assign it to some * other online CPU. */ -- Vitaly