From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58569ECAAA1 for ; Mon, 19 Sep 2022 16:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbiISQ5l (ORCPT ); Mon, 19 Sep 2022 12:57:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbiISQ5X (ORCPT ); Mon, 19 Sep 2022 12:57:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 153CF3D583 for ; Mon, 19 Sep 2022 09:57:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6747B81E32 for ; Mon, 19 Sep 2022 16:57:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F94AC433D6; Mon, 19 Sep 2022 16:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663606640; bh=e1c9LeDcXxqdtOIpd1ZwWgZxaen8/635/6PwkjadNqI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=coCRQUC/I78DboH/uTehOCvTmwkKHb6QIdO1MGfkWeVEnsoyjov9EZznXYSUozWGI MGEvBz4GEBrOEyicQANjm0Dd3XGb++LUILS/u4Tn14RkV9EdWFs6GDnn1fA+AMCWcv RUQ+BfG92weYl/UrM/VPh5h4a5k0iJdlUMt74bGifRDZCKBSpNNqYPb5ycQl1oKuB2 PjFTPe9GIBMBaIUXUqmIfLd/sf3EbSqvS2hFvrTfVniG8wK9/lxbP3zMOZcffgubdc 4I51T+xY1y0Mnw0FJOgg8Kv+2I8xHWSnS6H6Ojp9AeqY4IIV8YpgUxgQHcHfKh9pYq 2lTx6+Q5sqUog== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oaK58-00BACH-1G; Mon, 19 Sep 2022 17:57:18 +0100 Date: Mon, 19 Sep 2022 17:57:16 +0100 Message-ID: <87a66vl2tv.wl-maz@kernel.org> From: Marc Zyngier To: Sean Christopherson Cc: kvm@vger.kernel.org, Ricardo Koller , kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev, pbonzini@redhat.com, rananta@google.com, dmatlack@google.com, bgardon@google.com, reijiw@google.com, axelrasmussen@google.com, oupton@google.com, alexandru.elisei@arm.com, eric.auger@redhat.com Subject: Re: [PATCH v6 00/13] KVM: selftests: Add aarch64/page_fault_test In-Reply-To: References: <20220906180930.230218-1-ricarkol@google.com> <166358370892.2832387.8903539023908338224.b4-ty@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: seanjc@google.com, kvm@vger.kernel.org, ricarkol@google.com, kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev, pbonzini@redhat.com, rananta@google.com, dmatlack@google.com, bgardon@google.com, reijiw@google.com, axelrasmussen@google.com, oupton@google.com, alexandru.elisei@arm.com, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 19 Sep 2022 17:38:14 +0100, Sean Christopherson wrote: > > On Mon, Sep 19, 2022, Marc Zyngier wrote: > > On Tue, 6 Sep 2022 18:09:17 +0000, Ricardo Koller wrote: > > > This series adds a new aarch64 selftest for testing stage 2 fault handling for > > > various combinations of guest accesses (e.g., write, S1PTW), backing sources > > > (e.g., anon), and types of faults (e.g., read on hugetlbfs with a hole, write > > > on a readonly memslot). Each test tries a different combination and then checks > > > that the access results in the right behavior (e.g., uffd faults with the right > > > address and write/read flag). Some interesting combinations are: > > > > > > [...] > > > > Given how long this has been around, I've picked this series up, applying > > Oliver's fixes in the process. > > Any chance this can be undone? A big reason why this is at v6 is > because of the common API changes, and due to KVM Forum I've > effectively had three working days since this was posted, and others > have probably had even less, i.e. lack of reviews on v6 isn't > because no one cares. Hey, I'm still not back at work, and won't be for another week! But fair enough, if there is going to be a respin, I'd rather see that (and I'm less hung up on tests having been in -next for some time before sending out a PR that eventually reaches Linus). > It's not the end of the world if we have to fix things up on top, > but we'd avoid a decent amount of churn if we can instead unwind and > do a v7. No skin off my nose, as this leaves on its own topic branch. Now dropped. M. -- Without deviation from the norm, progress is not possible.