From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79ABC433E0 for ; Tue, 16 Mar 2021 12:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A30E6500A for ; Tue, 16 Mar 2021 12:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhCPMRr (ORCPT ); Tue, 16 Mar 2021 08:17:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:36380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbhCPMRM (ORCPT ); Tue, 16 Mar 2021 08:17:12 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60FD064FE0; Tue, 16 Mar 2021 12:17:11 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lM8dJ-001xW3-7h; Tue, 16 Mar 2021 12:17:09 +0000 Date: Tue, 16 Mar 2021 12:17:08 +0000 Message-ID: <87blbjfg3f.wl-maz@kernel.org> From: Marc Zyngier To: Quentin Perret Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Will Deacon , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 01/10] KVM: arm64: Provide KVM's own save/restore SVE primitives In-Reply-To: References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-2-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: qperret@google.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, broonie@kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 16 Mar 2021 10:31:46 +0000, Quentin Perret wrote: > > On Tuesday 16 Mar 2021 at 10:13:03 (+0000), Marc Zyngier wrote: > > diff --git a/arch/arm64/kvm/hyp/fpsimd.S b/arch/arm64/kvm/hyp/fpsimd.S > > index 01f114aa47b0..e4010d1acb79 100644 > > --- a/arch/arm64/kvm/hyp/fpsimd.S > > +++ b/arch/arm64/kvm/hyp/fpsimd.S > > @@ -19,3 +19,13 @@ SYM_FUNC_START(__fpsimd_restore_state) > > fpsimd_restore x0, 1 > > ret > > SYM_FUNC_END(__fpsimd_restore_state) > > + > > +SYM_FUNC_START(__sve_restore_state) > > + sve_load 0, x1, x2, 3, x4 > > + ret > > +SYM_FUNC_END(__sve_restore_state) > > Nit: maybe this could be named __sve_load_state() for consistency with > the EL1 version? Well, we already have the discrepancy for fpsimd in the same file, so I opted for another kind of consistency... > > > +SYM_FUNC_START(__sve_save_state) > > + sve_save 0, x1, 2 > > + ret > > +SYM_FUNC_END(__sve_restore_state) > > SYM_FUNC_END(__sve_save_state) here? Yup, good catch. Thanks, M. -- Without deviation from the norm, progress is not possible.