From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849DEC388F7 for ; Thu, 29 Oct 2020 02:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B2AE2076B for ; Thu, 29 Oct 2020 02:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="DvOqsTCf"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="R8WZe//0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbgJ2CBr (ORCPT ); Wed, 28 Oct 2020 22:01:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727794AbgJ1Vt1 (ORCPT ); Wed, 28 Oct 2020 17:49:27 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA867C0613D3; Wed, 28 Oct 2020 14:49:26 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1603919633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZN7gTMaQE9rZtoF/3JClNUhpDPOWII3Z0v/zsk1pW7Y=; b=DvOqsTCfJb//Gu7QniTg8aS3rdwxklw2TVI+sHxcDpoVjSql6wCXVQXYegUolgA+d1mElE tbylmYcxS3byoU49CeslFOqrj1SYPqXk00NPmWPVNsNwpSvKMJbJ7jx2c7G4WRXXhIFAC+ CPeUOshJVPkcBe0C4CLLDINzO4Ec0dvdzld+HhYYl+S82ZxoHUg/xsH9fGPq22aoDNGL/K mhGheXQunw7P8/igcnAToSOwKUisFT9x6VVPdFHJvbqpamRoRYUcy7ziiLKenlaGpxR3+0 0crL/f5reEyrGLxAE4MFUM+fQBN8sakeQnHRmtIKDhu6afo1sUoigwWkXXdIow== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1603919633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZN7gTMaQE9rZtoF/3JClNUhpDPOWII3Z0v/zsk1pW7Y=; b=R8WZe//0NE888iRDVHM3pZcAHWnxRbe/zZzK4/MnQh4TllKWr+JrVaCiEyALu4243gwqiZ Q37ahmWu/3/IosDA== To: Kees Cook , David Woodhouse Cc: x86@kernel.org, kvm , iommu@lists.linux-foundation.org, joro@8bytes.org, Paolo Bonzini , linux-kernel , linux-hyperv@vger.kernel.org, maz@misterjones.org, Dexuan Cui Subject: Re: [PATCH v3 15/35] PCI: vmd: Use msi_msg shadow structs In-Reply-To: <202010281347.2943F5B7@keescook> References: <20201024213535.443185-1-dwmw2@infradead.org> <20201024213535.443185-16-dwmw2@infradead.org> <202010281347.2943F5B7@keescook> Date: Wed, 28 Oct 2020 22:13:52 +0100 Message-ID: <87blgmf3zj.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Oct 28 2020 at 13:49, Kees Cook wrote: > On Sat, Oct 24, 2020 at 10:35:15PM +0100, David Woodhouse wrote: >> + memset(&msg, 0, sizeof(*msg); > > This should be: > > + memset(msg, 0, sizeof(*msg); memset(msg, 0, sizeof(*msg)); Then it compiles _and_ is correct :)