From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Li RongQing <lirongqing@baidu.com>,
kvm@vger.kernel.org, pbonzini@redhat.com
Cc: seanjc@google.com, lirongqing@baidu.com
Subject: Re: [v3][PATCH 1/2] KVM: x86: don't print when fail to read/write pv eoi memory
Date: Thu, 04 Nov 2021 12:22:58 +0100 [thread overview]
Message-ID: <87czngmagd.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1636024059-53855-1-git-send-email-lirongqing@baidu.com>
Li RongQing <lirongqing@baidu.com> writes:
> If guest gives MSR_KVM_PV_EOI_EN a wrong value, this printk() will
> be trigged, and kernel log is spammed with the useless message
>
> Fixes: 0d88800d5472 ("kvm: x86: ioapic and apic debug macros cleanup")
> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Paolo,
I'd Cc: stable@ here as these messages are not even ratelimited.
> ---
> arch/x86/kvm/lapic.c | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index d6ac32f..752c48e 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -676,31 +676,25 @@ static inline bool pv_eoi_enabled(struct kvm_vcpu *vcpu)
> static bool pv_eoi_get_pending(struct kvm_vcpu *vcpu)
> {
> u8 val;
> - if (pv_eoi_get_user(vcpu, &val) < 0) {
> - printk(KERN_WARNING "Can't read EOI MSR value: 0x%llx\n",
> - (unsigned long long)vcpu->arch.pv_eoi.msr_val);
> + if (pv_eoi_get_user(vcpu, &val) < 0)
> return false;
> - }
> +
> return val & KVM_PV_EOI_ENABLED;
> }
>
> static void pv_eoi_set_pending(struct kvm_vcpu *vcpu)
> {
> - if (pv_eoi_put_user(vcpu, KVM_PV_EOI_ENABLED) < 0) {
> - printk(KERN_WARNING "Can't set EOI MSR value: 0x%llx\n",
> - (unsigned long long)vcpu->arch.pv_eoi.msr_val);
> + if (pv_eoi_put_user(vcpu, KVM_PV_EOI_ENABLED) < 0)
> return;
> - }
> +
> __set_bit(KVM_APIC_PV_EOI_PENDING, &vcpu->arch.apic_attention);
> }
>
> static void pv_eoi_clr_pending(struct kvm_vcpu *vcpu)
> {
> - if (pv_eoi_put_user(vcpu, KVM_PV_EOI_DISABLED) < 0) {
> - printk(KERN_WARNING "Can't clear EOI MSR value: 0x%llx\n",
> - (unsigned long long)vcpu->arch.pv_eoi.msr_val);
> + if (pv_eoi_put_user(vcpu, KVM_PV_EOI_DISABLED) < 0)
> return;
> - }
> +
> __clear_bit(KVM_APIC_PV_EOI_PENDING, &vcpu->arch.apic_attention);
> }
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
prev parent reply other threads:[~2021-11-04 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 11:07 [v3][PATCH 1/2] KVM: x86: don't print when fail to read/write pv eoi memory Li RongQing
2021-11-04 11:07 ` [v3][PATCH 2/2] KVM: Clear pv eoi pending bit only when it is set Li RongQing
2021-11-04 11:32 ` Vitaly Kuznetsov
2021-11-04 11:22 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czngmagd.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).