From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B2EC433ED for ; Thu, 8 Apr 2021 11:22:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DDA66113C for ; Thu, 8 Apr 2021 11:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbhDHLW1 (ORCPT ); Thu, 8 Apr 2021 07:22:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58408 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbhDHLW0 (ORCPT ); Thu, 8 Apr 2021 07:22:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617880935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ssiNnsZ6XfvMIOQx/UIjvpGkHgwAq/U6xUsW4ZtB1bQ=; b=BL9WZilNHw+Y3pUuUT8vVP5XYSvR9c+MKS2WXFOWOcGkLsl5AiUHSfDe6HNfNx8krhNfZf 26U4Q3MbyJbabECEuSwcKcXmRqbRshSbUAWHramm2Q2Qqa7V4gOjNfIq5ArOFYe3qP/zE5 o5JiFMK6P2Kd+/dzyjJTdzU0FTMlHFY= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-_ASJfxYSM7WQOFQa9Mkwlg-1; Thu, 08 Apr 2021 07:22:13 -0400 X-MC-Unique: _ASJfxYSM7WQOFQa9Mkwlg-1 Received: by mail-ej1-f72.google.com with SMTP id k26so700992ejs.5 for ; Thu, 08 Apr 2021 04:22:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=ssiNnsZ6XfvMIOQx/UIjvpGkHgwAq/U6xUsW4ZtB1bQ=; b=T71srUqsv3pBvO6Xyrs8a0szDsHsLvAlCW04npZufSm3yWep4ybktQgF2dEjhei+Dc dYUsgXJ82gk8KHjV+tWomQg2lCI6NggVSOWm1yTYw7ol90gdmvgfd4u8cXjwzAbhqlgv YggsrNaXqKgrf4S8dznZn7q1S9D3NqZNybtP3aKTLV2lmndCmFpRwzkRLfoRI3ZkjbV/ /y3bxom4MO5EGsiN9pCtxPWo/gXppMAfvfEyHITJlPCohzkPZYzydX0AeSTELFw7sb6Y ij0AQ2T3UG0VGD8kOKeNtc4K3MT5aYZ9xibDlbgg/qH40uFj3FdqlVmT8t4cqHsONzrQ peBw== X-Gm-Message-State: AOAM530JnF2kY/N0uERDoaHUGXtNl9uV72WCjXYbzCkn8TuhgDibJOoC DK5NlOW8hDQwUpNV5HolbQRJAz0DBiKe6yCNFHHbMJ3vA3cPMW4t7TvC38Y2g4XlvOaTUVVQne6 bhHcjAsA22VhV X-Received: by 2002:a05:6402:c:: with SMTP id d12mr10604273edu.100.1617880932457; Thu, 08 Apr 2021 04:22:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5kZWFZe+2WZ6vDjqnSa/1c+6hqr71F8KhJ2yK/Q8ALfWlMlWLdAjtlCLTrF3PKtkjitUOqQ== X-Received: by 2002:a05:6402:c:: with SMTP id d12mr10604262edu.100.1617880932324; Thu, 08 Apr 2021 04:22:12 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id m14sm17251529edd.63.2021.04.08.04.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 04:22:11 -0700 (PDT) From: Vitaly Kuznetsov To: Vineeth Pillai , Lan Tianyu , Michael Kelley , Paolo Bonzini , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Wei Liu , Stephen Hemminger , Haiyang Zhang Cc: Vineeth Pillai , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "K. Y. Srinivasan" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH 6/7] KVM: SVM: hyper-v: Enlightened MSR-Bitmap support In-Reply-To: <5cf935068a9539146e033276b6d9a6c9b1e42119.1617804573.git.viremana@linux.microsoft.com> References: <5cf935068a9539146e033276b6d9a6c9b1e42119.1617804573.git.viremana@linux.microsoft.com> Date: Thu, 08 Apr 2021 13:22:10 +0200 Message-ID: <87czv5aun1.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Vineeth Pillai writes: > Enlightened MSR-Bitmap as per TLFS: > > "The L1 hypervisor may collaborate with the L0 hypervisor to make MSR > accesses more efficient. It can enable enlightened MSR bitmaps by setting > the corresponding field in the enlightened VMCS to 1. When enabled, L0 > hypervisor does not monitor the MSR bitmaps for changes. Instead, the L1 > hypervisor must invalidate the corresponding clean field after making > changes to one of the MSR bitmaps." > > Enable this for SVM. > > Related VMX changes: > commit ceef7d10dfb6 ("KVM: x86: VMX: hyper-v: Enlightened MSR-Bitmap support") > > Signed-off-by: Vineeth Pillai > --- > arch/x86/kvm/svm/svm.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 6287cab61f15..3562a247b7e8 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -646,6 +646,27 @@ static bool msr_write_intercepted(struct kvm_vcpu *vcpu, u32 msr) > return !!test_bit(bit_write, &tmp); > } > > +#if IS_ENABLED(CONFIG_HYPERV) > +static inline void hv_vmcb_dirty_nested_enlightenments(struct kvm_vcpu *vcpu) > +{ > + struct vmcb *vmcb = to_svm(vcpu)->vmcb; > + > + /* > + * vmcb can be NULL if called during early vcpu init. > + * And its okay not to mark vmcb dirty during vcpu init > + * as we mark it dirty unconditionally towards end of vcpu > + * init phase. > + */ > + if (vmcb && vmcb_is_clean(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS) && > + vmcb->hv_enlightenments.hv_enlightenments_control.msr_bitmap) > + vmcb_mark_dirty(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS); vmcb_is_clean() check seems to be superfluous, vmcb_mark_dirty() does no harm if the bit was already cleared. > +} > +#else > +static inline void hv_vmcb_dirty_nested_enlightenments(struct kvm_vcpu *vcpu) > +{ > +} > +#endif > + > static void set_msr_interception_bitmap(struct kvm_vcpu *vcpu, u32 *msrpm, > u32 msr, int read, int write) > { > @@ -677,6 +698,9 @@ static void set_msr_interception_bitmap(struct kvm_vcpu *vcpu, u32 *msrpm, > write ? clear_bit(bit_write, &tmp) : set_bit(bit_write, &tmp); > > msrpm[offset] = tmp; > + > + hv_vmcb_dirty_nested_enlightenments(vcpu); > + > } > > void set_msr_interception(struct kvm_vcpu *vcpu, u32 *msrpm, u32 msr, > @@ -1135,6 +1159,9 @@ static void hv_init_vmcb(struct vmcb *vmcb) > if (npt_enabled && > ms_hyperv.nested_features & HV_X64_NESTED_ENLIGHTENED_TLB) > hve->hv_enlightenments_control.enlightened_npt_tlb = 1; > + > + if (ms_hyperv.nested_features & HV_X64_NESTED_MSR_BITMAP) > + hve->hv_enlightenments_control.msr_bitmap = 1; > } > #else > static inline void hv_init_vmcb(struct vmcb *vmcb) -- Vitaly