kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: po-hsu.lin@canonical.com, kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCHv2] unittests.cfg: Increase timeout for apic test
Date: Thu, 15 Oct 2020 17:59:52 +0200	[thread overview]
Message-ID: <87d01j5vk7.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20201013091237.67132-1-po-hsu.lin@canonical.com>

Po-Hsu Lin <po-hsu.lin@canonical.com> writes:

> We found that on Azure cloud hyperv instance Standard_D48_v3, it will
> take about 45 seconds to run this apic test.
>
> It takes even longer (about 150 seconds) to run inside a KVM instance
> VM.Standard2.1 on Oracle cloud.
>
> Bump the timeout threshold to give it a chance to finish.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  x86/unittests.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index 872d679..c72a659 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -41,7 +41,7 @@ file = apic.flat
>  smp = 2
>  extra_params = -cpu qemu64,+x2apic,+tsc-deadline
>  arch = x86_64
> -timeout = 30
> +timeout = 240
>  
>  [ioapic]
>  file = ioapic.flat

AFAIR the default timeout for tests where timeout it not set explicitly
is 90s so don't you need to also modify it for other tests like
'apic-split', 'ioapic', 'ioapic-split', ... ?

I was thinking about introducing a 'timeout multiplier' or something to
run_tests.sh for running in slow (read: nested) environments, doing that
would allow us to keep reasonably small timeouts by default. This is
somewhat important as tests tend to hang and waiting for 4 minutes every
time is not great.

-- 
Vitaly


  reply	other threads:[~2020-10-15 16:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  9:12 [kvm-unit-tests PATCHv2] unittests.cfg: Increase timeout for apic test Po-Hsu Lin
2020-10-15 15:59 ` Vitaly Kuznetsov [this message]
2020-10-15 16:35   ` Sean Christopherson
2020-10-16 17:02     ` Paolo Bonzini
2020-10-16 17:40       ` Andrew Jones
2020-10-20  5:53         ` Thomas Huth
2020-10-20  8:49           ` Andrew Jones
2020-10-19 11:32     ` Vitaly Kuznetsov
2020-10-19 16:37       ` Christopherson, Sean J
2020-10-19 16:52         ` Nadav Amit
2020-10-20  8:48           ` Paolo Bonzini
2020-10-20 15:05             ` Christopherson, Sean J
2020-10-30  8:15   ` Po-Hsu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d01j5vk7.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=po-hsu.lin@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).