From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: linmiaohe@huawei.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
pbonzini@redhat.com, sean.j.christopherson@intel.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com
Subject: Re: [PATCH] KVM: VMX: remove duplicated segment cache clear
Date: Tue, 21 Jan 2020 10:14:16 +0100 [thread overview]
Message-ID: <87eevtf9xz.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20200121151518.27530-1-linmiaohe@huawei.com>
Miaohe Lin <linmiaohe@huawei.com> writes:
> vmx_set_segment() clears segment cache unconditionally, so we should not
> clear it again by calling vmx_segment_cache_clear().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index b5a0c2e05825..b32236e6b513 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu)
>
> vmx->rmode.vm86_active = 0;
>
> - vmx_segment_cache_clear(vmx);
> -
> vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR);
>
> flags = vmcs_readl(GUEST_RFLAGS);
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
next prev parent reply other threads:[~2020-01-21 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 15:15 [PATCH] KVM: VMX: remove duplicated segment cache clear Miaohe Lin
2020-01-21 9:14 ` Vitaly Kuznetsov [this message]
2020-01-21 12:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eevtf9xz.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).