From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "Suthikulpanit\, Suravee" <Suravee.Suthikulpanit@amd.com>
Cc: "joro\@8bytes.org" <joro@8bytes.org>,
"pbonzini\@redhat.com" <pbonzini@redhat.com>,
"rkrcmar\@redhat.com" <rkrcmar@redhat.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm\@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] svm/avic: Fix invalidate logical APIC id entry
Date: Fri, 22 Mar 2019 14:04:01 +0100 [thread overview]
Message-ID: <87ef6zcb7i.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20190322101706.9377-1-suravee.suthikulpanit@amd.com>
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com> writes:
> Only clear the valid bit when invalidate logical APIC id entry.
> The current logic clear the valid bit, but also set the rest of
> the bits (including reserved bits) to 1.
>
> Fixes: 98d90582be2e ('svm: Fix AVIC DFR and LDR handling')
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
> arch/x86/kvm/svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 7a4ce1a22ca0..f4fb766e474c 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -4640,7 +4640,7 @@ static void avic_invalidate_logical_id_entry(struct kvm_vcpu *vcpu)
> u32 *entry = avic_get_logical_id_entry(vcpu, svm->ldr_reg, flat);
>
> if (entry)
> - WRITE_ONCE(*entry, (u32) ~AVIC_LOGICAL_ID_ENTRY_VALID_MASK);
> + WRITE_ONCE(*entry, (u32)(*entry & ~AVIC_LOGICAL_ID_ENTRY_VALID_MASK));
I'm not sure how important this is, but this change creates a tiny time
window between reading from *entry and writing there. Should we use
atomic bitops instead?
> }
>
> static int avic_handle_ldr_update(struct kvm_vcpu *vcpu)
--
Vitaly
next prev parent reply other threads:[~2019-03-22 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 10:17 [PATCH] svm/avic: Fix invalidate logical APIC id entry Suthikulpanit, Suravee
2019-03-22 13:04 ` Vitaly Kuznetsov [this message]
2019-03-26 3:47 ` Suthikulpanit, Suravee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef6zcb7i.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).