From: Michael Ellerman <mpe@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Alistair Popple <alistair@popple.id.au>,
Alex Williamson <alex.williamson@redhat.com>,
Paul Mackerras <paulus@ozlabs.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Subject: Re: [PATCH kernel v2 4/4] powerpc/powernv/ioda: Remove obsolete iommu_table_ops::exchange callbacks
Date: Tue, 27 Aug 2019 14:48:41 +1000 [thread overview]
Message-ID: <87mufv2oye.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190826061705.92048-5-aik@ozlabs.ru>
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> As now we have xchg_no_kill/tce_kill, these are not used anymore so
> remove them.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> arch/powerpc/include/asm/iommu.h | 10 -----
> arch/powerpc/kernel/iommu.c | 26 +-----------
> arch/powerpc/platforms/powernv/pci-ioda.c | 50 -----------------------
> 3 files changed, 1 insertion(+), 85 deletions(-)
This doesn't build:
arch/powerpc/platforms/pseries/iommu.c:652:3: error: 'struct iommu_table_ops' has no member named 'exchange'
.exchange = tce_exchange_pseries,
^~~~~~~~
arch/powerpc/platforms/pseries/iommu.c:652:14: error: initialization of 'int (*)(struct iommu_table *, long int, long unsigned int *, enum dma_data_direction *, bool)' {aka 'int (*)(struct iommu_table *, long int, long unsigned int *, enum dma_data_direction *, _Bool)'} from incompatible pointer type 'int (*)(struct iommu_table *, long int, long unsigned int *, enum dma_data_direction *)' [-Werror=incompatible-pointer-types]
.exchange = tce_exchange_pseries,
^~~~~~~~~~~~~~~~~~~~
cheers
prev parent reply other threads:[~2019-08-27 4:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 6:17 [PATCH kernel v2 0/4] powerpc/powernv/kvm: Invalidate multiple TCEs at once Alexey Kardashevskiy
2019-08-26 6:17 ` [PATCH kernel v2 1/4] powerpc/powernv/ioda: Split out TCE invalidation from TCE updates Alexey Kardashevskiy
2019-08-26 6:17 ` [PATCH kernel v2 2/4] KVM: PPC: Invalidate multiple TCEs at once Alexey Kardashevskiy
2019-08-27 0:32 ` Paul Mackerras
2019-08-26 6:17 ` [PATCH kernel v2 3/4] vfio/spapr_tce: " Alexey Kardashevskiy
2019-08-26 6:17 ` [PATCH kernel v2 4/4] powerpc/powernv/ioda: Remove obsolete iommu_table_ops::exchange callbacks Alexey Kardashevskiy
2019-08-27 4:48 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mufv2oye.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=alistair@popple.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).