From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CEE5C432BE for ; Wed, 18 Aug 2021 09:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 035A360F39 for ; Wed, 18 Aug 2021 09:35:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234689AbhHRJgQ (ORCPT ); Wed, 18 Aug 2021 05:36:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33529 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233384AbhHRJc7 (ORCPT ); Wed, 18 Aug 2021 05:32:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629279137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RHYvNfODo5ETK+AbX2YYLKozZTeELQw3jUzDzquAaQ8=; b=Af/juhH7fjHGL4c37iuIJ7iAMLxiArAeLxSXk1wKhOF4lFmPSssYZkhHJM1nGOxotE4HB1 ias8Dlx8WPpf51qi0rfJoCfnZshly9VjiZ496apPTAgVaBAewI6wNyZrXZkCgoGYVgQK1n 84xeo5v41zbxUBSHlOwF9QjSrBiGqRY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-QikpU_boPjCmorLeQE6G_Q-1; Wed, 18 Aug 2021 05:32:16 -0400 X-MC-Unique: QikpU_boPjCmorLeQE6G_Q-1 Received: by mail-wm1-f71.google.com with SMTP id h11-20020a05600c350b00b002e6fd28807dso472941wmq.6 for ; Wed, 18 Aug 2021 02:32:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=RHYvNfODo5ETK+AbX2YYLKozZTeELQw3jUzDzquAaQ8=; b=Ash1Zuzsixyk6LB+MW58BxBVPqmm2iuO9GWUaLfZ7oH4KG58eXDd6mUK9H1UVQKMNu AjvdjSl3ilLGNbAi885vr02f++8uTatjZTf6qa9P+dU4/SrJdXgGGZD5Q9dI88OvCMgb OY3SDzDfYWJjX5/MigmP4kUlwcPpWN8TKs4URNUmiiGydqonAxq8lF+aAL18Vf4JG4sX t+FGjMafy693WcZNPQryLkTv9NpHejnET/kHpbUcd+q1iCUZf0dqQrS6Y+LqZ1ZNO//m a30NpbHc5cuEP8pj002Dm7AePgr7/OBACL6KlOPybBfukQ1EqhniXmQM6yFlPhOOKJck XBDg== X-Gm-Message-State: AOAM533+XqCppBXPxHVokhMmhOTK3H9hsdGqOId4KQ/6vgbaBa7C9pbe sAvoOo+h9UMfrst9VblWvFoLPrqL4c65TLVfTpTW7azaCtXAZMezgTeABJJOKUezC21qp7FmIHM JChNDHaxgDxox X-Received: by 2002:adf:f290:: with SMTP id k16mr9291920wro.88.1629279135302; Wed, 18 Aug 2021 02:32:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyyJoTAzImUF2IbKFC+1grXiIm6uPRSomp1hYc24EninkNxslFaPaoRrZa3p9prXkxmGnZEQ== X-Received: by 2002:adf:f290:: with SMTP id k16mr9291890wro.88.1629279135138; Wed, 18 Aug 2021 02:32:15 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id 204sm4784923wmb.38.2021.08.18.02.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 02:32:14 -0700 (PDT) From: Vitaly Kuznetsov To: Paolo Bonzini Cc: suleiman@google.com, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jim Mattson , Joerg Roedel , John Stultz , Sean Christopherson , Stephen Boyd , Wanpeng Li , kvm@vger.kernel.org, x86@kernel.org, Hikaru Nishida , linux-kernel@vger.kernel.org, dme@dme.org, tglx@linutronix.de, mlevitsk@redhat.com Subject: Re: [v2 PATCH 3/4] x86/kvm: Add host side support for virtual suspend time injection In-Reply-To: <2ec642dd-dde6-bee6-3de3-0fa78d288995@redhat.com> References: <20210806100710.2425336-1-hikalium@chromium.org> <20210806190607.v2.3.Ib0cb8ecae99f0ccd0e2814b310adba00b9e81d94@changeid> <2ec642dd-dde6-bee6-3de3-0fa78d288995@redhat.com> Date: Wed, 18 Aug 2021 11:32:13 +0200 Message-ID: <87o89vksiq.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Paolo Bonzini writes: > On 06/08/21 12:07, Hikaru Nishida wrote: >> +#if defined(CONFIG_KVM_VIRT_SUSPEND_TIMING) || \ >> + defined(CONFIG_KVM_VIRT_SUSPEND_TIMING_GUEST) >> +#define VIRT_SUSPEND_TIMING_VECTOR 0xec >> +#endif > > No need to use a new vector. You can rename the existing > MSR_KVM_ASYNC_PF_INT to MSR_KVM_HYPERVISOR_CALLBACK_INT or something > like that, and add the code to sysvec_kvm_asyncpf_interrupt. On the host side, I'd vote for keeping MSR_KVM_ASYNC_PF_INT for async PF mechanism only for two reasons: - We may want to use (currently reserved) upper 56 bits of it for new asyncPF related features (e.g. flags) and it would be unnatural to add them to 'MSR_KVM_HYPERVISOR_CALLBACK_INT' - We should probably leave it to the guest if it wants to share 'suspend time' notification interrupt with async PF (and if it actually wants to get one/another). On the guest side, it is perfectly fine to reuse HYPERVISOR_CALLBACK_VECTOR for everything. -- Vitaly