From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B450C43461 for ; Tue, 13 Apr 2021 14:26:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 642DE61221 for ; Tue, 13 Apr 2021 14:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231972AbhDMO1R (ORCPT ); Tue, 13 Apr 2021 10:27:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44463 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231856AbhDMO1Q (ORCPT ); Tue, 13 Apr 2021 10:27:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618324016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wBRPv3G5uNqKDsSO2MfNKj8YoTGefde97SCfUlwiDUw=; b=cc3cwT2WJPhaevOi9k10cDUc91ktri8/za5CS4ofPgteOe87ABupMeA4+uO8Jlydqh3PMh UYHgAVBdVtrLKo8ZEOSW482fusddBLKQ44nwOAUCcMvZeGvxoNJWHCXcOSjbqtIgzaWbKB DGQJu/E89FtZr230DH3+DTDNYQgDIjE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-BHoqLJfqMiyc3HQ0HQx5Nw-1; Tue, 13 Apr 2021 10:26:55 -0400 X-MC-Unique: BHoqLJfqMiyc3HQ0HQx5Nw-1 Received: by mail-ej1-f72.google.com with SMTP id di5so5121034ejc.1 for ; Tue, 13 Apr 2021 07:26:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wBRPv3G5uNqKDsSO2MfNKj8YoTGefde97SCfUlwiDUw=; b=f+4QbIwiEZkI9QYUiV23lINRbeiV/OzaQiZ6gD3y8W83A5xbNtTBVn+hJe358GtqfB jbn4OLSHFIZZbFMUk8fX/Qyg0v9aZxsz6L6G5tyKHjIFwRX/tjwtDJpqjkMEg0m6XqEC zxPf4+N0PCPFTr6eVi3Gy3FA3bvrN0Z+uyWCry95vCalxe6JrDlOkg0Vajc39iG4UGRc B6FsyjJ7eYOk1Vg/L+OKCU5rd2XttI4KMCd1x9fbSLla1eTRPfrmtARI/PtouSeNYPq0 S+oJhI3j5e9V/+MANiUB6XPLcj/2BomdIGrd04aGzq3yCcMUSKtG5Eu6eiCOU1ZSIz5K DsLQ== X-Gm-Message-State: AOAM532HrjVR4nWVjd7eC407zP6a14CLOONaB3/soTtvuT7Fydu2+Jsg AVqVOtBwWVrKvPFBetLxw7AurCYvYUEghgBwiJjicRqC5a3e2fey9qt/SKpMl4vYD5DmAiM7yl5 X0mWdIQlz8I7c X-Received: by 2002:a05:6402:344e:: with SMTP id l14mr35655737edc.184.1618324013943; Tue, 13 Apr 2021 07:26:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl2wCg7G5ZLN6NTfXLLG6LDFnftmIdSKu81ij0nvsNsooVaOdHUB697PVzQlupmIvKSlGHzA== X-Received: by 2002:a05:6402:344e:: with SMTP id l14mr35655703edc.184.1618324013808; Tue, 13 Apr 2021 07:26:53 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id nb29sm7767985ejc.118.2021.04.13.07.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:26:53 -0700 (PDT) From: Vitaly Kuznetsov To: Siddharth Chandrasekaran Cc: Alexander Graf , Evgeny Iakovlev , Liran Alon , Ioannis Aslanidis , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel Subject: Re: [PATCH v2 4/4] KVM: hyper-v: Advertise support for fast XMM hypercalls In-Reply-To: <5ec20918b06cad17cb43f04be212c5e21c18caea.1618244920.git.sidcha@amazon.de> References: <5ec20918b06cad17cb43f04be212c5e21c18caea.1618244920.git.sidcha@amazon.de> Date: Tue, 13 Apr 2021 16:26:52 +0200 Message-ID: <87pmyy5kgj.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Siddharth Chandrasekaran writes: > Now that all extant hypercalls that can use XMM registers (based on > spec) for input/outputs are patched to support them, we can start > advertising this feature to guests. > > Cc: Alexander Graf > Cc: Evgeny Iakovlev > Signed-off-by: Siddharth Chandrasekaran > --- > arch/x86/include/asm/hyperv-tlfs.h | 7 ++++++- > arch/x86/kvm/hyperv.c | 2 ++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h > index e6cd3fee562b..716f12be411e 100644 > --- a/arch/x86/include/asm/hyperv-tlfs.h > +++ b/arch/x86/include/asm/hyperv-tlfs.h > @@ -52,7 +52,7 @@ > * Support for passing hypercall input parameter block via XMM > * registers is available > */ > -#define HV_X64_HYPERCALL_PARAMS_XMM_AVAILABLE BIT(4) > +#define HV_X64_HYPERCALL_XMM_INPUT_AVAILABLE BIT(4) > /* Support for a virtual guest idle state is available */ > #define HV_X64_GUEST_IDLE_STATE_AVAILABLE BIT(5) > /* Frequency MSRs available */ > @@ -61,6 +61,11 @@ > #define HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE BIT(10) > /* Support for debug MSRs available */ > #define HV_FEATURE_DEBUG_MSRS_AVAILABLE BIT(11) > +/* > + * Support for returning hypercall ouput block via XMM > + * registers is available > + */ > +#define HV_X64_HYPERCALL_XMM_OUTPUT_AVAILABLE BIT(15) > /* stimer Direct Mode is available */ > #define HV_STIMER_DIRECT_MODE_AVAILABLE BIT(19) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index 1f9959aba70d..55838c266bcd 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -2254,6 +2254,8 @@ int kvm_get_hv_cpuid(struct kvm_vcpu *vcpu, struct kvm_cpuid2 *cpuid, > ent->ebx |= HV_POST_MESSAGES; > ent->ebx |= HV_SIGNAL_EVENTS; > > + ent->edx |= HV_X64_HYPERCALL_XMM_INPUT_AVAILABLE; > + ent->edx |= HV_X64_HYPERCALL_XMM_OUTPUT_AVAILABLE; > ent->edx |= HV_FEATURE_FREQUENCY_MSRS_AVAILABLE; > ent->edx |= HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE; With 'ouput' typo fixed, Reviewed-by: Vitaly Kuznetsov -- Vitaly