From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC6BC43462 for ; Mon, 10 May 2021 10:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6606761184 for ; Mon, 10 May 2021 10:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhEJKBK convert rfc822-to-8bit (ORCPT ); Mon, 10 May 2021 06:01:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:46586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbhEJKBK (ORCPT ); Mon, 10 May 2021 06:01:10 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F09F961042; Mon, 10 May 2021 10:00:05 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lg2hm-000Lan-Qh; Mon, 10 May 2021 11:00:03 +0100 Date: Mon, 10 May 2021 11:00:02 +0100 Message-ID: <87wns6oqn1.wl-maz@kernel.org> From: Marc Zyngier To: "Zhu, Lingshan" Cc: Jason Wang , mst@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" In-Reply-To: References: <20210508071152.722425-1-lingshan.zhu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: lingshan.zhu@intel.com, jasowang@redhat.com, mst@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 10 May 2021 09:32:54 +0100, "Zhu, Lingshan" wrote: > > > > On 5/10/2021 3:09 PM, Zhu, Lingshan wrote: > > > > > > On 5/10/2021 12:34 PM, Jason Wang wrote: > >> > >> 在 2021/5/10 上午11:00, Zhu, Lingshan 写道: > >>> > >>> > >>> On 5/10/2021 10:43 AM, Jason Wang wrote: > >>>> > >>>> 在 2021/5/8 下午3:11, Zhu Lingshan 写道: > >>>>> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. > >>>>> > >>>>> The reverted commit may cause VM freeze on arm64 platform. > >>>>> Because on arm64 platform, stop a consumer will suspend the VM, > >>>>> the VM will freeze without a start consumer > >>>>> > >>>>> Signed-off-by: Zhu Lingshan > >>>> > >>>> > >>>> Acked-by: Jason Wang > >>>> > >>>> Please resubmit with the formal process of stable > >>>> (stable-kernel-rules.rst). > >>> sure, I will re-submit it to stable kernel once it is merged into > >>> Linus tree. > >>> > >>> Thanks > >> > >> > >> I think it's better to resubmit (option 1), see how > >> stable-kernel-rules.rst said: > >> > >> "" > >> > >> :ref:`option_1` is **strongly** preferred, is the easiest and most > >> common. > >> :ref:`option_2` and :ref:`option_3` are more useful if the patch > >> isn't deemed > >> worthy at the time it is applied to a public git tree (for > >> instance, because > >> it deserves more regression testing first). > >> > >> """ > >> > >> Thanks > > OK, works for me, I will add cc stable, and resubmit it soon > > > > Thanks! > I just seeMarc has already added "Cc: stable@vger.kernel.org", and > he would take the patch in his tree, so I think no need to resend. That's fine, I can fix things up myself and queue the fix for -rc2. Thanks, M. -- Without deviation from the norm, progress is not possible.