From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 086EFC2D0A3 for ; Mon, 9 Nov 2020 14:08:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF02820665 for ; Mon, 9 Nov 2020 14:08:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="hSDIbLVt"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="29SYYngZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730900AbgKIOIU (ORCPT ); Mon, 9 Nov 2020 09:08:20 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:51470 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgKIOIT (ORCPT ); Mon, 9 Nov 2020 09:08:19 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1604930897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Za9y7vEVZbcDkAkC7l7dzQWgdMKeP4nlkFK2BA7cwS8=; b=hSDIbLVtm/ANSBZsSoQ0B1BPQJALf1e3Gm9+rr/beaSXG9ZhGPP36aaUEGXMKjCRg6N+px 0keE0c4Wnelx1v0FWQ1vkLYGusenOw61vdBfmdIsCZ2JfclTjyKTKsuemdGZMT/BK03BJX yTr/cQEhWxRBSYR+ui5FmPFV7vt04XVhAvduv8WDSAUiyWXboZd3CA0/NKHEimulpxhiNy u3b8izFPHXOqZX86NYlngvxMjUuYv6XZ4T9NH5vQKRQ9AQiqiSfIV8/9qdrioIk6B6D3le Toe/vMFXsSuqXYYSS6k8rnEVZ4oKHh6LKqmG9uCHfNduQKQTXGcydgQbCAW0yA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1604930897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Za9y7vEVZbcDkAkC7l7dzQWgdMKeP4nlkFK2BA7cwS8=; b=29SYYngZN3K6tp0wh7XnzjkglnmzPe5zF+Bh/pZRJabS3DucWRsFYJrbFsVyaI0vJ7phI1 wQWk/joCQQXXJkBA== To: "Raj\, Ashok" Cc: Jason Gunthorpe , Dan Williams , "Tian\, Kevin" , "Jiang\, Dave" , Bjorn Helgaas , "vkoul\@kernel.org" , "Dey\, Megha" , "maz\@kernel.org" , "bhelgaas\@google.com" , "alex.williamson\@redhat.com" , "Pan\, Jacob jun" , "Liu\, Yi L" , "Lu\, Baolu" , "Kumar\, Sanjay K" , "Luck\, Tony" , "kwankhede\@nvidia.com" , "eric.auger\@redhat.com" , "parav\@mellanox.com" , "rafael\@kernel.org" , "netanelg\@mellanox.com" , "shahafs\@mellanox.com" , "yan.y.zhao\@linux.intel.com" , "pbonzini\@redhat.com" , "Ortiz\, Samuel" , "Hossain\, Mona" , "dmaengine\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-pci\@vger.kernel.org" , "kvm\@vger.kernel.org" , Ashok Raj Subject: Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection In-Reply-To: References: Date: Mon, 09 Nov 2020 15:08:17 +0100 Message-ID: <87y2jaipwu.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Nov 09 2020 at 12:14, Thomas Gleixner wrote: > On Sun, Nov 08 2020 at 15:58, Ashok Raj wrote: >> On Sun, Nov 08, 2020 at 07:47:24PM +0100, Thomas Gleixner wrote: >> But for SIOV devices there is no PASID filtering at the remap level since >> interrupt messages don't carry PASID in the TLP. > > Why do we need PASID for VMM integrity? > > If the device sends a message then the remap unit will see the requester > ID of the device and if the message it sends is not That made me look at patch 4/17 which adds DEVMSI support to the remap code: > + case X86_IRQ_ALLOC_TYPE_DEV_MSI: > + irte_prepare_msg(msg, index, sub_handle); > break; It does not setup any requester-id filter in IRTE. How is that supposed to be correct? Thanks, tglx