From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames Date: Thu, 16 Jul 2009 15:43:27 +0200 Message-ID: <87y6qoaglc.fsf@pike.pond.sub.org> References: <1245862739.6278.7.camel@localhost> <1246063310.6278.115.camel@localhost> <1246511321.6429.31.camel@localhost> <4A4C754D.10109@redhat.com> <4A4CAD86.9020607@us.ibm.com> <4A4CB39F.5070506@redhat.com> <1247041831.6297.12.camel@localhost> <1247644283.14246.3.camel@localhost> <4A5DF252.50408@us.ibm.com> <4A5DF875.2020808@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Blue Swirl , Kevin Wolf , kvm-devel , linuxram@us.ibm.com, qemu-devel@nongnu.org, Jan Kiszka , Paul Brook To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46635 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756770AbZGPNpi (ORCPT ); Thu, 16 Jul 2009 09:45:38 -0400 In-Reply-To: <4A5DF875.2020808@us.ibm.com> (Anthony Liguori's message of "Wed\, 15 Jul 2009 10\:40\:37 -0500") Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori writes: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img >> > > The explicit ordering part seems clunky to me. How about: > > -drive name=vda,if=virtio -drive.vda.file filename.img > > What's nice about this syntax is it generalizes well. You could have: > > -drive.vda.if virtio -drive.vda.file filename.img > -net nic,model=rtl8139,name=foo -net.foo.macaddr 00:11:43:55:44:22 Sanest proposal so far. Just put filenames in separate arguments, as with almost every other program. Instead of name=, let's use id= from Gerd's qdev work. Why "-drive.ID.NAME VALUE", "-net.ID.NAME VALUE" and so forth, i.e. one option per object with parameters? Assuming the ID name space is flat, a single option suffices. What about "-set ID.NAME=VALUE"? Quoting is problematic. Not only because it necessarily breaks some filenames that used to work, also because the shell quotes, too. I don't enjoy counting backslashes.