From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B081BC48BE5 for ; Tue, 22 Jun 2021 15:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 980646113E for ; Tue, 22 Jun 2021 15:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232203AbhFVP5s (ORCPT ); Tue, 22 Jun 2021 11:57:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:48602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232166AbhFVP5r (ORCPT ); Tue, 22 Jun 2021 11:57:47 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E23F261040; Tue, 22 Jun 2021 15:55:31 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvikK-009Cz7-01; Tue, 22 Jun 2021 16:55:28 +0100 Date: Tue, 22 Jun 2021 16:55:27 +0100 Message-ID: <87zgvhc2s0.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, James Morse , Suzuki K Poulose , Eric Auger , Hector Martin , Mark Rutland , Zenghui Yu , kernel-team@android.com Subject: Re: [PATCH v4 5/9] KVM: arm64: vgic: move irq->get_input_level into an ops structure In-Reply-To: References: <20210601104005.81332-1-maz@kernel.org> <20210601104005.81332-6-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, marcan@marcan.st, mark.rutland@arm.com, yuzenghui@huawei.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 15 Jun 2021 15:45:03 +0100, Alexandru Elisei wrote: > > Hi Marc, > > On 6/1/21 11:40 AM, Marc Zyngier wrote: > > We already have the option to attach a callback to an interrupt > > to retrieve its pending state. As we are planning to expand this > > facility, move this callback into its own data structure. > > > > This will limit the size of individual interrupts as the ops > > structures can be shared across multiple interrupts. > > I can't figure out what you mean by that. If you are referring to > struct vgic_irq, the change I am seeing is a pointer being replaced > by another pointer, which shouldn't affect its size. Are you > referring to something else? Eventually, we have more than just a pointer (we also get flags in the same structure), so this saves some space. > > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/arch_timer.c | 8 ++++++-- > > arch/arm64/kvm/vgic/vgic.c | 14 +++++++------- > > include/kvm/arm_vgic.h | 28 +++++++++++++++++----------- > > 3 files changed, 30 insertions(+), 20 deletions(-) > > > > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > > index 74e0699661e9..e2288b6bf435 100644 > > --- a/arch/arm64/kvm/arch_timer.c > > +++ b/arch/arm64/kvm/arch_timer.c > > @@ -1116,6 +1116,10 @@ bool kvm_arch_timer_get_input_level(int vintid) > > return kvm_timer_should_fire(timer); > > } > > > > +static struct irq_ops arch_timer_irq_ops = { > > + .get_input_level = kvm_arch_timer_get_input_level, > > Since kvm_arch_timer_get_input_level() is used only indirectly, through the > get_input_level field of the static struct, I think we can make > kvm_arch_timer_get_input_level() static and remove the declaration from > include/kvm/arm_arch_timer.h. Ah, good point. I'll stash a patch on top of the existing series (I'm trying not to change what is currently queued in -next). Thanks, M. -- Without deviation from the norm, progress is not possible.