From: David Hildenbrand <david@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v7 4/4] s390x: SCLP unit test
Date: Mon, 13 Jan 2020 12:00:00 +0100 [thread overview]
Message-ID: <8d7fb5c4-9e2c-e28a-16c0-658afcc8178d@redhat.com> (raw)
In-Reply-To: <20200110184050.191506-5-imbrenda@linux.ibm.com>
> +/**
> + * Test some bits in the instruction format that are specified to be ignored.
> + */
> +static void test_instbits(void)
> +{
> + SCCBHeader *h = (SCCBHeader *)pagebuf;
> + int cc;
> +
> + expect_pgm_int();
> + sclp_mark_busy();
> + h->length = 8;
> + sclp_setup_int();
> +
> + asm volatile(
> + " .insn rre,0xb2204200,%1,%2\n" /* servc %1,%2 */
> + " ipm %0\n"
> + " srl %0,28"
> + : "=&d" (cc) : "d" (valid_code), "a" (__pa(pagebuf))
> + : "cc", "memory");
> + if (lc->pgm_int_code) {
> + sclp_handle_ext();
> + cc = 1;
> + } else if (!cc)
> +
I wonder if something like the following would be possible:
expect_pgm_int();
...
asm volatiole();
...
sclp_wait_busy();
check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
We would have to clear "sclp_busy" when we get a progam interrupt on a
servc instruction - shouldn't be too hard to add to the program
exception handler.
> + report(cc == 0, "Instruction format ignored bits");
> +}
> +
> +/**
> + * Find a valid READ INFO command code; not all codes are always allowed, and
> + * probing should be performed in the right order.
> + */
> +static void find_valid_sclp_code(void)
> +{
> + const unsigned int commands[] = { SCLP_CMDW_READ_SCP_INFO_FORCED,
> + SCLP_CMDW_READ_SCP_INFO };
> + SCCBHeader *h = (SCCBHeader *)pagebuf;
> + int i, cc;
> +
> + for (i = 0; i < ARRAY_SIZE(commands); i++) {
> + sclp_mark_busy();
> + memset(h, 0, sizeof(*h));
> + h->length = 4096;
> +
> + valid_code = commands[i];
> + cc = sclp_service_call(commands[i], h);
> + if (cc)
> + break;
> + if (h->response_code == SCLP_RC_NORMAL_READ_COMPLETION)
> + return;
> + if (h->response_code != SCLP_RC_INVALID_SCLP_COMMAND)
> + break;
> + }
> + valid_code = 0;
This can be dropped because ...
> + report_abort("READ_SCP_INFO failed");
... you abort here.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-13 11:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 18:40 [kvm-unit-tests PATCH v7 0/4] s390x: SCLP Unit test Claudio Imbrenda
2020-01-10 18:40 ` [kvm-unit-tests PATCH v7 1/4] s390x: export sclp_setup_int Claudio Imbrenda
2020-01-10 18:40 ` [kvm-unit-tests PATCH v7 2/4] s390x: sclp: add service call instruction wrapper Claudio Imbrenda
2020-01-10 18:40 ` [kvm-unit-tests PATCH v7 3/4] s390x: lib: add SPX and STPX " Claudio Imbrenda
2020-01-13 9:42 ` Janosch Frank
2020-01-13 12:27 ` Claudio Imbrenda
2020-01-13 10:42 ` David Hildenbrand
2020-01-10 18:40 ` [kvm-unit-tests PATCH v7 4/4] s390x: SCLP unit test Claudio Imbrenda
2020-01-13 11:00 ` David Hildenbrand [this message]
2020-01-13 12:33 ` Claudio Imbrenda
2020-01-13 12:48 ` David Hildenbrand
2020-01-13 12:58 ` Claudio Imbrenda
2020-01-13 13:10 ` David Hildenbrand
2020-01-13 14:05 ` Claudio Imbrenda
2020-01-13 14:43 ` David Hildenbrand
2020-01-13 15:24 ` Claudio Imbrenda
2020-01-13 16:06 ` David Hildenbrand
2020-01-13 16:17 ` Claudio Imbrenda
2020-01-15 9:57 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d7fb5c4-9e2c-e28a-16c0-658afcc8178d@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).