From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0A1C48BE6 for ; Fri, 11 Jun 2021 12:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 271E861246 for ; Fri, 11 Jun 2021 12:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbhFKMQO (ORCPT ); Fri, 11 Jun 2021 08:16:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32370 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbhFKMQN (ORCPT ); Fri, 11 Jun 2021 08:16:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623413655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tshLc4zdYGgPabfNvrWwtgUPpGh1iSBRoaKHJCb/8hw=; b=PMI2b6zBnWHuxdj543hlg7h0EXf0fTk0tnlT6pTbIzGd0QQG09ZoMII4o0VpoVLgUFTViD 3MojeNqYmPqNFj8TGJvxxazwWXBzZ86l5Cwf2Q7x/2SB39QRhjJm/FleCl2NuEixi9+3NK sBFcpACCHILfCb2QetHonb5Dg5bJjAg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-kgzWkUi_PTmatpxJTtEWzA-1; Fri, 11 Jun 2021 08:14:13 -0400 X-MC-Unique: kgzWkUi_PTmatpxJTtEWzA-1 Received: by mail-wm1-f69.google.com with SMTP id n2-20020a05600c3b82b02901aeb7a4ac06so5317911wms.5 for ; Fri, 11 Jun 2021 05:14:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tshLc4zdYGgPabfNvrWwtgUPpGh1iSBRoaKHJCb/8hw=; b=Lrq09NrkGjnsWvHmlgx8swl8qKxQL476hm7IbCa4VPuyevWpJ/SoVv4mFp0OE/VHJo b6yUpyE/Spw8chu5SLVvpLz1Zh1YikyfzyRMzHHuMHiKK+PGerQiZOtSW067FS9fZXpx FFhqjv1fV1/KfV+vyM8YFkQqee7uK0f2Y4FuxTyM2x539fnhD9IoWOLilXXUiiTA+I2F nRJzjG4cxakvi7VwsLqGhZnBW87PGnuVyYb7U6iTUA0uiPerYR9d/E55NPuYS+M+wZ/x Sj3FzMAFBFVgD1jVMNo4liAeNpC8qZN69q/UFUdMX2Kol2o/0mpnkU2bDAfXUKPJOMIn ygBQ== X-Gm-Message-State: AOAM5327FWmS2m+qYVXrKayWZoYfEFfCMjbTHVshBZYLtBvy1Ch5/6M6 LDJVt3e8EvQjKBGCSew1FBMwL+m2UU5QLeGyNkzIe/eQRqzIzaTvkqzi8ORgfaycgDjBEfTw8gk qnSj2VT+WpFGN X-Received: by 2002:a05:600c:3650:: with SMTP id y16mr3677453wmq.92.1623413652697; Fri, 11 Jun 2021 05:14:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzekCA0/z805DZlMHydl4+u+pU/IhlWHIqCvhI6IwFtHm385E+SV0tWtc3pGZK67eFkb8/Udw== X-Received: by 2002:a05:600c:3650:: with SMTP id y16mr3677424wmq.92.1623413652485; Fri, 11 Jun 2021 05:14:12 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id r18sm6837910wro.62.2021.06.11.05.14.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 05:14:11 -0700 (PDT) Subject: Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones To: Christian Borntraeger , Jing Zhang , KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan References: <20210603211426.790093-1-jingzhangos@google.com> <20210603211426.790093-2-jingzhangos@google.com> <03f3fa03-6f61-7864-4867-3dc332a9d6f3@de.ibm.com> <050e9d8e-278d-278c-13f7-ea0b39d13fbe@de.ibm.com> From: Paolo Bonzini Message-ID: <8dd7259c-d0f6-6816-178f-ab0f0b486955@redhat.com> Date: Fri, 11 Jun 2021 14:14:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <050e9d8e-278d-278c-13f7-ea0b39d13fbe@de.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 11/06/21 14:08, Christian Borntraeger wrote: >> >> I always interpreted it as "number of times the KVM page table >> management code needed other CPUs to learn about new page tables". >> Whether the broadcast is done in software or hardware shouldn't >> matter; either way I suppose there is still some traffic on the bus >> involved. > > > My point is that KVM page table management on s390x completely > piggy-backs on the qemu address space page table management from common > code for the last level. > And due to the way we handle page tables we also do not teach "other > CPUs". We always teach the whole system with things like IPTE. But that just means that you'll have fewer KVM-exclusive and thus nicer numbers than x86 or ARM. :) It still makes sense to count gmap_flush_tlb calls. Paolo