From: gengdongjiu <gengdongjiu@huawei.com> To: Peter Maydell <peter.maydell@linaro.org> Cc: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, Fam Zheng <fam@euphon.net>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, "xuwei (O)" <xuwei5@huawei.com>, Jonathan Cameron <jonathan.cameron@huawei.com>, James Morse <james.morse@arm.com>, "QEMU Developers" <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>, qemu-arm <qemu-arm@nongnu.org>, Zheng Xiang <zhengxiang9@huawei.com>, Linuxarm <linuxarm@huawei.com> Subject: Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address Date: Fri, 17 Jan 2020 18:36:37 +0800 Message-ID: <9110de9c-7522-2823-22be-4ba9212026fb@huawei.com> (raw) In-Reply-To: <CAFEAcA9z9KDHmvh6WsrCPj_FTvNmOfhatxNQDftNG+ZKZN0wAA@mail.gmail.com> On 2020/1/17 0:44, Peter Maydell wrote: >> .minimum_version_id = 1, >> .fields = (VMStateField[]) { >> - VMSTATE_STRUCT(ged_state, AcpiGedState, 1, vmstate_ged_state, GEDState), >> + VMSTATE_STRUCT(ged_state, AcpiGedState, 1, >> + vmstate_ged_state, GEDState), >> + VMSTATE_STRUCT(ghes_state, AcpiGedState, 1, >> + vmstate_ghes_state, AcpiGhesState), >> VMSTATE_END_OF_LIST(), >> }, >> .subsections = (const VMStateDescription * []) { > You can't just add fields to an existing VMStateDescription > like this -- it will break migration compatibility. Instead you > need to add a new subsection to this vmstate, with a '.needed' > function which indicates when the subsection should be present. Thanks Peter's pointing out. I will change it. > > thanks > -- PMM > . >
next prev parent reply index Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-08 11:32 [PATCH v22 0/9] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng 2020-01-08 11:32 ` [PATCH v22 1/9] hw/arm/virt: Introduce a RAS machine option Dongjiu Geng 2020-01-08 11:32 ` [PATCH v22 2/9] docs: APEI GHES generation and CPER record description Dongjiu Geng 2020-01-15 15:11 ` Igor Mammedov 2020-01-08 11:32 ` [PATCH v22 3/9] ACPI: Build related register address fields via hardware error fw_cfg blob Dongjiu Geng 2020-01-23 15:14 ` Igor Mammedov 2020-02-02 14:01 ` gengdongjiu 2020-01-08 11:32 ` [PATCH v22 4/9] ACPI: Build Hardware Error Source Table Dongjiu Geng 2020-01-23 15:48 ` Igor Mammedov 2020-02-02 14:21 ` gengdongjiu 2020-02-05 16:43 ` Jonathan Cameron 2020-02-10 11:18 ` gengdongjiu 2020-01-08 11:32 ` [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address Dongjiu Geng 2020-01-16 16:44 ` Peter Maydell 2020-01-17 10:36 ` gengdongjiu [this message] 2020-02-13 15:28 ` gengdongjiu 2020-01-17 7:39 ` Philippe Mathieu-Daudé 2020-01-17 10:47 ` gengdongjiu 2020-01-17 11:20 ` Philippe Mathieu-Daudé 2020-01-28 14:41 ` Igor Mammedov 2020-01-28 16:19 ` Igor Mammedov 2020-02-02 12:44 ` gengdongjiu 2020-02-03 7:51 ` Igor Mammedov 2020-01-08 11:32 ` [PATCH v22 6/9] KVM: Move hwpoison page related functions into kvm-all.c Dongjiu Geng 2020-01-08 11:32 ` [PATCH v22 7/9] ACPI: Record Generic Error Status Block(GESB) table Dongjiu Geng 2020-01-28 15:29 ` Igor Mammedov 2020-02-02 13:42 ` gengdongjiu 2020-02-03 7:55 ` Igor Mammedov 2020-01-08 11:32 ` [PATCH v22 8/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng 2020-01-16 16:28 ` Peter Maydell 2020-01-16 16:40 ` Peter Maydell 2020-01-17 10:04 ` gengdongjiu 2020-01-20 12:15 ` Peter Maydell 2020-01-22 15:30 ` gengdongjiu 2020-01-08 11:32 ` [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries Dongjiu Geng 2020-01-16 16:46 ` Peter Maydell 2020-01-17 7:22 ` Philippe Mathieu-Daudé 2020-01-17 10:16 ` gengdongjiu 2020-01-17 11:09 ` Peter Maydell 2020-01-17 11:22 ` Philippe Mathieu-Daudé 2020-01-19 8:19 ` gengdongjiu 2020-01-17 12:19 ` Michael S. Tsirkin 2020-01-09 3:38 ` [PATCH v22 0/9] Add ARMv8 RAS virtualization support in QEMU gengdongjiu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9110de9c-7522-2823-22be-4ba9212026fb@huawei.com \ --to=gengdongjiu@huawei.com \ --cc=ehabkost@redhat.com \ --cc=fam@euphon.net \ --cc=imammedo@redhat.com \ --cc=james.morse@arm.com \ --cc=jonathan.cameron@huawei.com \ --cc=kvm@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=shannon.zhaosl@gmail.com \ --cc=xuwei5@huawei.com \ --cc=zhengxiang9@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ kvm@vger.kernel.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git