From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8C9C433E0 for ; Tue, 19 Jan 2021 14:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1F8E2312E for ; Tue, 19 Jan 2021 14:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389186AbhASOxH (ORCPT ); Tue, 19 Jan 2021 09:53:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56308 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405839AbhASNng (ORCPT ); Tue, 19 Jan 2021 08:43:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611063721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MVFHB8eb6HiH2Ux0DyyuochO0r+NbqyILgiZBkee9hI=; b=Hjdqst7ltGTozqLLsNFaylZoFX1uxbRIeikOzJLc4zSdem53Lo6lf825mYolLrV1+1cQjo 7ifYAY27lDLUOZt3lvppy5/JBSlf2Hrlk/3Ge9L6FRpcjZ2XOZOssuYW7DeQH2caXoSSA3 Wvuw+J+aGFi6ftnnokvWy0fvYZT+lJU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-542-GzidLzgZOSC_8u4VftwvIQ-1; Tue, 19 Jan 2021 08:41:58 -0500 X-MC-Unique: GzidLzgZOSC_8u4VftwvIQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB091CE646; Tue, 19 Jan 2021 13:41:56 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-157.ams2.redhat.com [10.36.112.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7412B5E1B5; Tue, 19 Jan 2021 13:41:48 +0000 (UTC) Subject: Re: [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Jiaxun Yang Cc: Fam Zheng , Laurent Vivier , kvm@vger.kernel.org, Viktor Prutyanov , qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Alistair Francis , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Greg Kurz , qemu-ppc@nongnu.org, Paolo Bonzini , Kevin Wolf , Max Reitz , =?UTF-8?Q?Alex_Benn=c3=a9e?= , David Gibson References: <20210118063808.12471-1-jiaxun.yang@flygoat.com> <20210118063808.12471-9-jiaxun.yang@flygoat.com> <20210118103345.GE1789637@redhat.com> From: Thomas Huth Message-ID: <929c3ec1-9419-908a-6b5e-ce3ae78f6011@redhat.com> Date: Tue, 19 Jan 2021 14:41:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118103345.GE1789637@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 18/01/2021 11.33, Daniel P. Berrangé wrote: > On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote: >> Alpine Linux[1] is a security-oriented, lightweight Linux distribution >> based on musl libc and busybox. >> >> It it popular among Docker guests and embedded applications. >> >> Adding it to test against different libc. >> >> [1]: https://alpinelinux.org/ >> >> Signed-off-by: Jiaxun Yang >> --- >> tests/docker/dockerfiles/alpine.docker | 57 ++++++++++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> create mode 100644 tests/docker/dockerfiles/alpine.docker >> >> diff --git a/tests/docker/dockerfiles/alpine.docker b/tests/docker/dockerfiles/alpine.docker >> new file mode 100644 >> index 0000000000..5be5198d00 >> --- /dev/null >> +++ b/tests/docker/dockerfiles/alpine.docker >> @@ -0,0 +1,57 @@ >> + >> +FROM alpine:edge >> + >> +RUN apk update >> +RUN apk upgrade >> + >> +# Please keep this list sorted alphabetically >> +ENV PACKAGES \ >> + alsa-lib-dev \ >> + bash \ >> + bison \ > > This shouldn't be required. bison and flex were required to avoid some warnings in the past while compiling the dtc submodule ... but I thought we got rid of the problem at one point in time, so this can be removed now, indeed. >> + build-base \ > > This seems to be a meta packae that pulls in other > misc toolchain packages. Please list the pieces we > need explicitly instead. Looking at the "Depends" list on https://pkgs.alpinelinux.org/package/v3.3/main/x86/build-base there are only 6 dependencies and we need most of those for QEMU anyway, so I think it is ok to keep build-base here. >> + coreutils \ >> + curl-dev \ >> + flex \ > > This shouldn't be needed. > >> + git \ >> + glib-dev \ >> + glib-static \ >> + gnutls-dev \ >> + gtk+3.0-dev \ >> + libaio-dev \ >> + libcap-dev \ > > Should not be required, as we use cap-ng. Right. >> + libcap-ng-dev \ >> + libjpeg-turbo-dev \ >> + libnfs-dev \ >> + libpng-dev \ >> + libseccomp-dev \ >> + libssh-dev \ >> + libusb-dev \ >> + libxml2-dev \ >> + linux-headers \ > > Is this really needed ? We don't install kernel-headers on other > distros AFAICT. I tried a build without this package, and it works fine indeed. >> + lzo-dev \ >> + mesa-dev \ >> + mesa-egl \ >> + mesa-gbm \ >> + meson \ >> + ncurses-dev \ >> + ninja \ >> + paxmark \ > > What is this needed for ? Seems like it also can be dropped. >> + perl \ >> + pulseaudio-dev \ >> + python3 \ >> + py3-sphinx \ >> + shadow \ > > Is this really needed ? See: https://www.spinics.net/lists/kvm/msg231556.html I can remove the superfluous packages when picking up the patch, no need to respin just because of this. Thomas