From: Paolo Bonzini <pbonzini@redhat.com>
To: Yi Wang <up2wing@gmail.com>, Yi Wang <wang.yi59@zte.com.cn>
Cc: rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
wang.liang82@zte.com.cn
Subject: Re: [PATCH] kvm: x86: some tsc debug cleanup
Date: Mon, 15 Jul 2019 13:56:45 +0200 [thread overview]
Message-ID: <92dd9aa1-a23d-bc80-6a36-9732a6a730e2@redhat.com> (raw)
In-Reply-To: <499986B6-E3E3-4A43-A820-8D9B5E05F14B@gmail.com>
On 15/07/19 06:50, Yi Wang wrote:
> Hi Paolo,
> Would you help to review this patch, plz?
> Many thanks.
I have queued it now.
Paolo
> ---
> Best wishes
> Yi Wang
>
>> 在 2019年7月6日,01:10,Yi Wang <wang.yi59@zte.com.cn> 写道:
>>
>> There are some pr_debug in TSC code, which may have
>> been no use, so remove them as Paolo suggested.
>>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> ---
>> arch/x86/kvm/x86.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index fafd81d..86f9861 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -1518,9 +1518,6 @@ static void kvm_get_time_scale(uint64_t scaled_hz, uint64_t base_hz,
>>
>> *pshift = shift;
>> *pmultiplier = div_frac(scaled64, tps32);
>> -
>> - pr_debug("%s: base_hz %llu => %llu, shift %d, mul %u\n",
>> - __func__, base_hz, scaled_hz, shift, *pmultiplier);
>> }
>>
>> #ifdef CONFIG_X86_64
>> @@ -1763,12 +1760,10 @@ void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr)
>> vcpu->arch.virtual_tsc_khz == kvm->arch.last_tsc_khz) {
>> if (!kvm_check_tsc_unstable()) {
>> offset = kvm->arch.cur_tsc_offset;
>> - pr_debug("kvm: matched tsc offset for %llu\n", data);
>> } else {
>> u64 delta = nsec_to_cycles(vcpu, elapsed);
>> data += delta;
>> offset = kvm_compute_tsc_offset(vcpu, data);
>> - pr_debug("kvm: adjusted tsc offset by %llu\n", delta);
>> }
>> matched = true;
>> already_matched = (vcpu->arch.this_tsc_generation == kvm->arch.cur_tsc_generation);
>> @@ -1787,8 +1782,6 @@ void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr)
>> kvm->arch.cur_tsc_write = data;
>> kvm->arch.cur_tsc_offset = offset;
>> matched = false;
>> - pr_debug("kvm: new tsc generation %llu, clock %llu\n",
>> - kvm->arch.cur_tsc_generation, data);
>> }
>>
>> /*
>> @@ -6857,7 +6850,6 @@ static void kvm_timer_init(void)
>> cpufreq_register_notifier(&kvmclock_cpufreq_notifier_block,
>> CPUFREQ_TRANSITION_NOTIFIER);
>> }
>> - pr_debug("kvm: max_tsc_khz = %ld\n", max_tsc_khz);
>>
>> cpuhp_setup_state(CPUHP_AP_X86_KVM_CLK_ONLINE, "x86/kvm/clk:online",
>> kvmclock_cpu_online, kvmclock_cpu_down_prep);
>> --
>> 1.8.3.1
>>
prev parent reply other threads:[~2019-07-15 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 17:10 [PATCH] kvm: x86: some tsc debug cleanup Yi Wang
2019-07-15 4:50 ` Yi Wang
2019-07-15 11:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92dd9aa1-a23d-bc80-6a36-9732a6a730e2@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=up2wing@gmail.com \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=x86@kernel.org \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).