From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C261C47E49 for ; Tue, 22 Oct 2019 00:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02E24214B2 for ; Tue, 22 Oct 2019 00:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730590AbfJVA51 (ORCPT ); Mon, 21 Oct 2019 20:57:27 -0400 Received: from mga12.intel.com ([192.55.52.136]:11591 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729620AbfJVA50 (ORCPT ); Mon, 21 Oct 2019 20:57:26 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 17:57:26 -0700 X-IronPort-AV: E=Sophos;i="5.67,325,1566889200"; d="scan'208";a="191296939" Received: from xiaoyaol-mobl.ccr.corp.intel.com (HELO [10.239.13.123]) ([10.239.13.123]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 21 Oct 2019 17:57:24 -0700 Subject: Re: [PATCH] KVM: X86: Make fpu allocation a common function To: Paolo Bonzini , Sean Christopherson Cc: Vitaly Kuznetsov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jim Mattson References: <20191014162247.61461-1-xiaoyao.li@intel.com> <87y2xn462e.fsf@vitty.brq.redhat.com> <6cc430c1-5729-c2d3-df11-3bf1ec1272f8@intel.com> <245dcfe2-d167-fdec-a371-506352d3c684@redhat.com> <11318bab-a377-bb8c-b881-76331c92f11e@intel.com> <10300339-e4cb-57b0-ac2f-474604551df0@redhat.com> <20191017160508.GA20903@linux.intel.com> From: Xiaoyao Li Message-ID: <93bb79d0-287b-c7e9-59a2-1e30d1f5500b@intel.com> Date: Tue, 22 Oct 2019 08:57:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 10/21/2019 9:09 PM, Paolo Bonzini wrote: > On 17/10/19 18:05, Sean Christopherson wrote: >> On Wed, Oct 16, 2019 at 11:41:05AM +0200, Paolo Bonzini wrote: >>> On 16/10/19 09:48, Xiaoyao Li wrote: >>>> BTW, could you have a look at the series I sent yesterday to refactor >>>> the vcpu creation flow, which is inspired partly by this issue. Any >>>> comment and suggestion is welcomed since I don't want to waste time on >>>> wrong direction. >>> >>> Yes, that's the series from which I'll take your patch. >> >> Can you hold off on taking that patch? I'm pretty sure we can do more >> cleanup in that area, with less code. >> > > Should I hold off on the whole "Refactor vcpu creation flow of x86 arch" > series then? > Yes, please just leave them aside. If could, you can have an eye on my "v3 Minor cleanup and refactor about vmcs" Thanks, -Xiaoyao