From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] mips: Add KVM T&E segment support for
 TCG
Date: Mon, 31 Jul 2017 13:47:48 -0700
Message-ID: <93cb4cb7-842c-1a37-c2dd-a7c522076a1d@twiddle.net>
References: <cover.6535001d6b9cd2357109d19b1060e3f6a2b958a7.1501506432.git-series.james.hogan@imgtec.com>
 <ad80a5d3ff807996b3cdf70504cab7efd66c4295.1501506432.git-series.james.hogan@imgtec.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Yongbok Kim <yongbok.kim@imgtec.com>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        Aurelien Jarno <aurelien@aurel32.net>
To: James Hogan <james.hogan@imgtec.com>, qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:37618 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751059AbdGaUrv (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 31 Jul 2017 16:47:51 -0400
Received: by mail-pf0-f194.google.com with SMTP id 72so6958995pfl.4
        for <kvm@vger.kernel.org>; Mon, 31 Jul 2017 13:47:51 -0700 (PDT)
In-Reply-To: <ad80a5d3ff807996b3cdf70504cab7efd66c4295.1501506432.git-series.james.hogan@imgtec.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/31/2017 06:09 AM, James Hogan wrote:
> +static int mips_um_ksegs;
> +
>   uint64_t cpu_mips_kseg0_to_phys(void *opaque, uint64_t addr)
>   {
>       return addr & 0x1fffffffll;
> @@ -38,3 +40,13 @@ uint64_t cpu_mips_kvm_um_phys_to_kseg0(void *opaque, uint64_t addr)
>   {
>       return addr | 0x40000000ll;
>   }
> +
> +int mips_um_ksegs_enabled(void)

bool?

Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>


r~