From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Wanpeng Li" <wanpengli@tencent.com>,
"Jim Mattson" <jmattson@google.com>,
"Joerg Roedel" <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Daniel Díaz" <daniel.diaz@linaro.org>
Subject: Re: [PATCH] KVM: x86/mmu: Avoid modulo operator on 64-bit value to fix i386 build
Date: Sat, 24 Oct 2020 08:29:06 +0200 [thread overview]
Message-ID: <94427d37-03af-6d78-2039-cd326710904b@redhat.com> (raw)
In-Reply-To: <20201024031150.9318-1-sean.j.christopherson@intel.com>
On 24/10/20 05:11, Sean Christopherson wrote:
> Replace a modulo operator with the more common pattern for computing the
> gfn "offset" of a huge page to fix an i386 build error.
>
> arch/x86/kvm/mmu/tdp_mmu.c:212: undefined reference to `__umoddi3'
>
> Fixes: 2f2fad0897cb ("kvm: x86/mmu: Add functions to handle changed TDP SPTEs")
> Reported-by: Daniel Díaz <daniel.diaz@linaro.org>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
>
> Linus, do you want to take this directly so that it's in rc1? I don't
> know whether Paolo will be checking mail before then
Yes, I am. I also have another bugfix, I was going to wait a couple
days for any -rc1 issues to pop up but they came up faster than that.
Paolo
prev parent reply other threads:[~2020-10-24 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 3:11 [PATCH] KVM: x86/mmu: Avoid modulo operator on 64-bit value to fix i386 build Sean Christopherson
2020-10-24 6:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94427d37-03af-6d78-2039-cd326710904b@redhat.com \
--to=pbonzini@redhat.com \
--cc=daniel.diaz@linaro.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).