From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v4 3/3] s390x/spec_ex: Add test of EXECUTE with odd target address
Date: Tue, 04 Apr 2023 10:57:59 +0200 [thread overview]
Message-ID: <94dcda382e095bb562e1e552c7bf44ed22949972.camel@linux.ibm.com> (raw)
In-Reply-To: <2e22a705-47c1-53e2-c539-63db5b92f44a@redhat.com>
On Mon, 2023-04-03 at 17:38 +0200, Thomas Huth wrote:
> On 17/03/2023 14.32, Nina Schoetterl-Glausch wrote:
> > The EXECUTE instruction executes the instruction at the given target
> > address. This address must be halfword aligned, otherwise a
> > specification exception occurs.
> > Add a test for this.
> >
> > Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> > ---
> > s390x/spec_ex.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/s390x/spec_ex.c b/s390x/spec_ex.c
> > index ab023347..b4b9095f 100644
> > --- a/s390x/spec_ex.c
> > +++ b/s390x/spec_ex.c
> > @@ -177,6 +177,30 @@ static int short_psw_bit_12_is_0(void)
> > return 0;
> > }
> >
> > +static int odd_ex_target(void)
> > +{
> > + uint64_t pre_target_addr;
> > + int to = 0, from = 0x0dd;
> > +
> > + asm volatile ( ".pushsection .text.ex_odd\n"
> > + " .balign 2\n"
> > + "pre_odd_ex_target:\n"
> > + " . = . + 1\n"
> > + " lr %[to],%[from]\n"
> > + " .popsection\n"
> > +
> > + " larl %[pre_target_addr],pre_odd_ex_target\n"
> > + " ex 0,1(%[pre_target_addr])\n"
> > + : [pre_target_addr] "=&a" (pre_target_addr),
> > + [to] "+d" (to)
> > + : [from] "d" (from)
> > + );
> > +
> > + assert((pre_target_addr + 1) & 1);
> > + report(to != from, "did not perform ex with odd target");
> > + return 0;
> > +}
>
> Hi Nina,
>
> FWIW, this fails to compile with Clang v15 here:
>
> s390x/spec_ex.c:187:4: error: symbol 'pre_odd_ex_target' is already defined
> "pre_odd_ex_target:\n"
> ^
> <inline asm>:3:1: note: instantiated into assembly here
> pre_odd_ex_target:
>
> No clue yet why that happens ... but compiling with Clang seems to be broken
> on some other spots, too, so this is not really critical right now ;-)
Thanks, I guess it inlines the function and emits the asm twice.
Interestingly clang cannot load the address of the misaligned_code symbol in C code due to alignement,
so I had to work around that, too.
>
> Thomas
>
next prev parent reply other threads:[~2023-04-04 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 13:32 [kvm-unit-tests PATCH v4 0/3] s390x: Add misaligned instruction tests Nina Schoetterl-Glausch
2023-03-17 13:32 ` [kvm-unit-tests PATCH v4 1/3] s390x/spec_ex: Use PSW macro Nina Schoetterl-Glausch
2023-03-17 13:32 ` [kvm-unit-tests PATCH v4 2/3] s390x/spec_ex: Add test introducing odd address into PSW Nina Schoetterl-Glausch
2023-03-17 13:32 ` [kvm-unit-tests PATCH v4 3/3] s390x/spec_ex: Add test of EXECUTE with odd target address Nina Schoetterl-Glausch
2023-04-03 15:38 ` Thomas Huth
2023-04-04 8:57 ` Nina Schoetterl-Glausch [this message]
2023-03-17 14:41 ` [kvm-unit-tests PATCH v4 0/3] s390x: Add misaligned instruction tests Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94dcda382e095bb562e1e552c7bf44ed22949972.camel@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).