* [kvm-unit-tests PATCH] s390x: Fix vector stfle checks
@ 2021-05-03 12:47 Janosch Frank
2021-05-03 12:52 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Janosch Frank @ 2021-05-03 12:47 UTC (permalink / raw)
To: kvm; +Cc: david, thuth, imbrenda, cohuck
134 is for bcd
135 is for the vector enhancements
Not the other way around...
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Suggested-by: David Hildenbrand <david@redhat.com>
---
s390x/vector.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/s390x/vector.c b/s390x/vector.c
index d1b6a571..b052de55 100644
--- a/s390x/vector.c
+++ b/s390x/vector.c
@@ -53,7 +53,7 @@ static void test_add(void)
/* z14 vector extension test */
static void test_ext1_nand(void)
{
- bool has_vext = test_facility(134);
+ bool has_vext = test_facility(135);
static struct prm {
__uint128_t a,b,c;
} prm __attribute__((aligned(16)));
@@ -79,7 +79,7 @@ static void test_ext1_nand(void)
/* z14 bcd extension test */
static void test_bcd_add(void)
{
- bool has_bcd = test_facility(135);
+ bool has_bcd = test_facility(134);
static struct prm {
__uint128_t a,b,c;
} prm __attribute__((aligned(16)));
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: Fix vector stfle checks
2021-05-03 12:47 [kvm-unit-tests PATCH] s390x: Fix vector stfle checks Janosch Frank
@ 2021-05-03 12:52 ` David Hildenbrand
2021-05-03 12:54 ` Cornelia Huck
2021-05-03 13:06 ` Claudio Imbrenda
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2021-05-03 12:52 UTC (permalink / raw)
To: Janosch Frank, kvm; +Cc: thuth, imbrenda, cohuck
On 03.05.21 14:47, Janosch Frank wrote:
> 134 is for bcd
> 135 is for the vector enhancements
>
> Not the other way around...
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> ---
> s390x/vector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/vector.c b/s390x/vector.c
> index d1b6a571..b052de55 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -53,7 +53,7 @@ static void test_add(void)
> /* z14 vector extension test */
> static void test_ext1_nand(void)
> {
> - bool has_vext = test_facility(134);
> + bool has_vext = test_facility(135);
> static struct prm {
> __uint128_t a,b,c;
> } prm __attribute__((aligned(16)));
> @@ -79,7 +79,7 @@ static void test_ext1_nand(void)
> /* z14 bcd extension test */
> static void test_bcd_add(void)
> {
> - bool has_bcd = test_facility(135);
> + bool has_bcd = test_facility(134);
> static struct prm {
> __uint128_t a,b,c;
> } prm __attribute__((aligned(16)));
>
Reviewed-by: David Hildenbrand <david@redhat.com>
thanks!
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: Fix vector stfle checks
2021-05-03 12:47 [kvm-unit-tests PATCH] s390x: Fix vector stfle checks Janosch Frank
2021-05-03 12:52 ` David Hildenbrand
@ 2021-05-03 12:54 ` Cornelia Huck
2021-05-03 13:06 ` Claudio Imbrenda
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2021-05-03 12:54 UTC (permalink / raw)
To: Janosch Frank; +Cc: kvm, david, thuth, imbrenda
On Mon, 3 May 2021 12:47:13 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> 134 is for bcd
> 135 is for the vector enhancements
>
> Not the other way around...
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> ---
> s390x/vector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: Fix vector stfle checks
2021-05-03 12:47 [kvm-unit-tests PATCH] s390x: Fix vector stfle checks Janosch Frank
2021-05-03 12:52 ` David Hildenbrand
2021-05-03 12:54 ` Cornelia Huck
@ 2021-05-03 13:06 ` Claudio Imbrenda
2 siblings, 0 replies; 4+ messages in thread
From: Claudio Imbrenda @ 2021-05-03 13:06 UTC (permalink / raw)
To: Janosch Frank; +Cc: kvm, david, thuth, cohuck
On Mon, 3 May 2021 12:47:13 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> 134 is for bcd
> 135 is for the vector enhancements
>
> Not the other way around...
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/vector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/vector.c b/s390x/vector.c
> index d1b6a571..b052de55 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -53,7 +53,7 @@ static void test_add(void)
> /* z14 vector extension test */
> static void test_ext1_nand(void)
> {
> - bool has_vext = test_facility(134);
> + bool has_vext = test_facility(135);
> static struct prm {
> __uint128_t a,b,c;
> } prm __attribute__((aligned(16)));
> @@ -79,7 +79,7 @@ static void test_ext1_nand(void)
> /* z14 bcd extension test */
> static void test_bcd_add(void)
> {
> - bool has_bcd = test_facility(135);
> + bool has_bcd = test_facility(134);
> static struct prm {
> __uint128_t a,b,c;
> } prm __attribute__((aligned(16)));
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-03 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 12:47 [kvm-unit-tests PATCH] s390x: Fix vector stfle checks Janosch Frank
2021-05-03 12:52 ` David Hildenbrand
2021-05-03 12:54 ` Cornelia Huck
2021-05-03 13:06 ` Claudio Imbrenda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).