From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99136C433DF for ; Thu, 21 May 2020 15:40:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6854C207D8 for ; Thu, 21 May 2020 15:40:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aA6nrH98" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729786AbgEUPkQ (ORCPT ); Thu, 21 May 2020 11:40:16 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:38791 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728267AbgEUPkQ (ORCPT ); Thu, 21 May 2020 11:40:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590075614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kenpgJBk4auwpqa56sHWeaXAdh8oFne+jS5kW7dDT3Q=; b=aA6nrH98tbB8DmLvjITj9G3b+pz+kXrhGXJ2y7ExdS+K2nUO3mnooKDwSOpEEzLWM6VVzh gYPl/kw7qlE2LrUZ6JimwzUgH3nR02qUrzJgZOkmCN1lXqtSLvIlr/AOA9xix48tqktOqE 8TcgeZcR5LjCG1v3Jntb2FI6/7Gn8u8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-dlcgbeTKPtehoqhw7hX0zg-1; Thu, 21 May 2020 11:40:07 -0400 X-MC-Unique: dlcgbeTKPtehoqhw7hX0zg-1 Received: by mail-wr1-f72.google.com with SMTP id e1so586892wrm.3 for ; Thu, 21 May 2020 08:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kenpgJBk4auwpqa56sHWeaXAdh8oFne+jS5kW7dDT3Q=; b=RGhCVDO5XqWd4fj9a9SAHV25Ru2ZbtaNjPbSFQSHHAb7dBOUd+cq5SKIjv1JnwrXBd l6edQMOST+GWgWNXLTx1H/mSJUeD+9a97Gc7XrlQ5BnSPJpMu8TCSAEAYLmgMTr/N9XE iY+FAV/RenE5+08R6CfHgAcZMPf57GBpyus72VJhMFyJ+gLz5C/8e0SSETzZVzg+MWYu D+pKT5WWg7gu7xTO7TS+HRZCMEWleTmy7vTFIV/3CfvKIi7CJACQIAriQzaK+JQVsK/T kKbRQWWoi9xS3KLzpzfv83Vwwgp/6nK9rgbf27Ax/w+Emnz5YsdJIoSDofXpwq+O9PP5 BU4w== X-Gm-Message-State: AOAM533js+OCu+fHrwdzIsExS9OLgbtz02lNYGTQamQ5HntEA2Gpytrq YPaDHhyG+2e2xkgaHkACOUgeh+KYJpNZ++BzqE9g79aLJxnj8r0q3tAa6ykJF4Kj4kKjDvCUhMN XVHXIaxK//eGr X-Received: by 2002:adf:eb08:: with SMTP id s8mr4857962wrn.361.1590075606569; Thu, 21 May 2020 08:40:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjLbdazE1MurwXiqGxMChHJ6avy7iQksM+O+Le37BmWF/JoDDdLxLXN9DoW1cPErnwFF5huA== X-Received: by 2002:adf:eb08:: with SMTP id s8mr4857943wrn.361.1590075606355; Thu, 21 May 2020 08:40:06 -0700 (PDT) Received: from [192.168.178.58] ([151.21.160.154]) by smtp.gmail.com with ESMTPSA id a17sm2925213wmm.23.2020.05.21.08.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2020 08:40:05 -0700 (PDT) Subject: Re: [PATCH v2 0/7] exec/memory: Enforce checking MemTxResult values To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , kvm@vger.kernel.org, qemu-arm@nongnu.org, Richard Henderson References: <20200518155308.15851-1-f4bug@amsat.org> From: Paolo Bonzini Message-ID: <97559075-f7f3-3b18-a34d-3e7a419817ab@redhat.com> Date: Thu, 21 May 2020 17:40:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200518155308.15851-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 18/05/20 17:53, Philippe Mathieu-Daudé wrote: > Various places ignore the MemTxResult indicator of > transaction failed. Fix the easy places. > The rest are the DMA devices, which require deeper > analysis. > > Since v1: > - Dropped "exec/memory: Emit warning when MemTxResult is ignored" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg704180.html > > Philippe Mathieu-Daudé (7): > exec: Let address_space_read/write_cached() propagate MemTxResult > exec: Propagate cpu_memory_rw_debug() error > disas: Let disas::read_memory() handler return EIO on error > hw/elf_ops: Do not ignore write failures when loading ELF > hw/arm/boot: Abort if set_kernel_args() fails > accel/kvm: Let KVM_EXIT_MMIO return error > hw/core/loader: Assert loading ROM regions succeeds at reset > > include/exec/cpu-all.h | 1 + > include/exec/memory.h | 19 +++++++++++-------- > include/hw/elf_ops.h | 11 ++++++++--- > accel/kvm/kvm-all.c | 13 +++++++------ > disas.c | 13 ++++++++----- > exec.c | 28 ++++++++++++++++------------ > hw/arm/boot.c | 19 +++++++++++++------ > hw/core/loader.c | 8 ++++++-- > 8 files changed, 70 insertions(+), 42 deletions(-) > Queued patches 1-4, thanks. Paolo