From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D39C432C3 for ; Sat, 16 Nov 2019 00:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 711F0206D5 for ; Sat, 16 Nov 2019 00:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbfKPA7E convert rfc822-to-8bit (ORCPT ); Fri, 15 Nov 2019 19:59:04 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2104 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727128AbfKPA7E (ORCPT ); Fri, 15 Nov 2019 19:59:04 -0500 Received: from lhreml708-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 2BCFE9E064E08B3D09D5; Sat, 16 Nov 2019 00:59:02 +0000 (GMT) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by lhreml708-cah.china.huawei.com (10.201.108.49) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 16 Nov 2019 00:59:01 +0000 Received: from dggeme755-chm.china.huawei.com (10.3.19.101) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5; Sat, 16 Nov 2019 00:59:00 +0000 Received: from dggeme755-chm.china.huawei.com ([10.7.64.71]) by dggeme755-chm.china.huawei.com ([10.7.64.71]) with mapi id 15.01.1713.004; Sat, 16 Nov 2019 08:58:58 +0800 From: gengdongjiu To: Igor Mammedov CC: "zhengxiang (A)" , "pbonzini@redhat.com" , "mst@redhat.com" , "shannon.zhaosl@gmail.com" , "peter.maydell@linaro.org" , "lersek@redhat.com" , "james.morse@arm.com" , "mtosatti@redhat.com" , "rth@twiddle.net" , "ehabkost@redhat.com" , "Jonathan Cameron" , "xuwei (O)" , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , "qemu-arm@nongnu.org" , Linuxarm , "Wanghaibin (D)" Subject: Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Thread-Topic: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Thread-Index: AdWbyMkE/1gyxkpeREeYn2g+7NgH+g== Date: Sat, 16 Nov 2019 00:58:58 +0000 Message-ID: <99a06454b0fa4eac9116af9ec978aaea@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.148.208.123] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > On Fri, 15 Nov 2019 14:32:47 +0000 > gengdongjiu wrote: > > > > > + */ > > > > +static void acpi_ghes_build_notify(GArray *table, const uint8_t > > > > +type) > > > > > > typically format should be build_WHAT(), so > > > build_ghes_hw_error_notification() > > > > > > And I'd move this out into its own patch. > > > this applies to other trivial in-depended sub-tables, that take all data needed to construct them from supplied arguments. > > > > I very used your suggested method in previous series[1], but other > > maintainer suggested to move this function to this file, because he > > think only GHES used it > > Using this file is ok, what I've meant for you to split function from this patch into a separate smaller patch. > > With the way code split now I have to review 2 big complex patches at the same which makes reviewing hard and I have a hard time > convincing myself that code it correct. > > Moving small self-contained chunks of code in to separate smaller patches makes review easier. Ok, got it. Thanks very much for the explanations