From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A87CC433FF for ; Tue, 30 Jul 2019 12:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A30C2087F for ; Tue, 30 Jul 2019 12:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730317AbfG3MK6 (ORCPT ); Tue, 30 Jul 2019 08:10:58 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54270 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726717AbfG3MK6 (ORCPT ); Tue, 30 Jul 2019 08:10:58 -0400 Received: by mail-wm1-f68.google.com with SMTP id x15so56938741wmj.3 for ; Tue, 30 Jul 2019 05:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9L0zBGqIjlWL1IQrDXZZd5jCWfrUHuNyOkNCDrFw/Cs=; b=tSok8UIOPkAfKaNjn099xbWL5Todm04CMf66CDQuFZL9WTcPNTnnVzSMsMbvBGt68Z 1fvPx4IzXL9UOYdlUH8PQ9puFp5V2+DuJfy+0M9+ZAsO/82QBL5s4exPmLKjmahxdS5d Eu7R63j/O7hL+gVN0PrHyQNwB9WdRwEmcy7vX4I66xwYr5f6GXYFsMo37lhTowcrgYAD 7/jSBciZfPJroxrJFNY6EDngpcUlr8WqAScvYjr1jNMEGAOhopT4XqRTmgOb2mOHlQbq /G81G6BgsvDWGMngpIHhpknwnFHvvBEc+Mdjl6WRduyiVMH5b7CASnZX0BLNK2Cmu5Br Z3ZQ== X-Gm-Message-State: APjAAAUL/FuPO+B5cVx+/fe5TXkSpE+s/Cs4Tf05DELasGQFLc+8HLXI 3jIi49lpdmDWcUop0DKBSIWYBQ== X-Google-Smtp-Source: APXvYqzRKfHoZNVIgIXgBiYl7T8xPjJrXf2ElRHPMC0DZvjUOPtbRAo+bHcxkpSIp0MMlJYsQjsIbQ== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr105796251wmk.79.1564488656203; Tue, 30 Jul 2019 05:10:56 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:29d3:6123:6d5f:2c04? ([2001:b07:6468:f312:29d3:6123:6d5f:2c04]) by smtp.gmail.com with ESMTPSA id t15sm56691815wrx.84.2019.07.30.05.10.55 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 05:10:55 -0700 (PDT) Subject: Re: [RFC PATCH 06/16] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls To: Anup Patel Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Radim K , Daniel Lezcano , Thomas Gleixner , Atish Patra , Alistair Francis , Damien Le Moal , Christoph Hellwig , "kvm@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20190729115544.17895-1-anup.patel@wdc.com> <20190729115544.17895-7-anup.patel@wdc.com> <3caa5b31-f5ed-98cd-2bdf-88d8cb837919@redhat.com> <536673cd-3b84-4e56-6042-de73a536653f@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <9f84c328-c5ad-b3cc-df0f-05f113476341@redhat.com> Date: Tue, 30 Jul 2019 14:10:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 30/07/19 14:08, Anup Patel wrote: >> Still, I would prefer all the VS CSRs to be accessible via the get/set >> reg ioctls. > We had implemented VS CSRs access to user-space but then we > removed it to keep this series simple and easy to review. We thought > of adding it later when we deal with Guest/VM migration. > > Do you want it to be added as part of this series ? Yes, please. It's not enough code to deserve a separate patch, and it is useful for debugging. Paolo