kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saar Amar <Saar.Amar@microsoft.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Subject: RE: KVM: x86: Fix emulation of sysenter
Date: Wed, 19 Jun 2019 12:47:06 +0000	[thread overview]
Message-ID: <AM0PR83MB0307821E5CFD654F2E5F7403F1E50@AM0PR83MB0307.EURPRD83.prod.outlook.com> (raw)
In-Reply-To: <53b1ac7e-0170-b966-d3f0-298e291e9bdd@redhat.com>

Yeah I see there is not flow to en_sysenter which doesn't pass this logic. Thanks

-----Original Message-----
From: Paolo Bonzini <pbonzini@redhat.com> 
Sent: Tuesday, June 18, 2019 5:12 PM
To: Saar Amar <Saar.Amar@microsoft.com>; kvm@vger.kernel.org
Cc: Radim Krčmář <rkrcmar@redhat.com>
Subject: Re: KVM: x86: Fix emulation of sysenter

On 18/06/19 15:19, Saar Amar wrote:
> I found a bug in sysenter emulation. Patch attached both in plaintext 
> and as patch file.

Do you have a testcase for this?  RF is cleared for all instructions here:

        if (ctxt->rep_prefix && (ctxt->d & String))
                ctxt->eflags |= X86_EFLAGS_RF;
        else
                ctxt->eflags &= ~X86_EFLAGS_RF;


just before em_sysenter is called.

Paolo

      reply	other threads:[~2019-06-19 12:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AM0PR83MB0307F44E915135F79E291058F1EA0@AM0PR83MB0307.EURPRD83.prod.outlook.com>
2019-06-18 14:12 ` KVM: x86: Fix emulation of sysenter Paolo Bonzini
2019-06-19 12:47   ` Saar Amar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR83MB0307821E5CFD654F2E5F7403F1E50@AM0PR83MB0307.EURPRD83.prod.outlook.com \
    --to=saar.amar@microsoft.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).