From: "Zhang, Xiantao" <xiantao.zhang@intel.com>
To: Avi Kivity <avi@redhat.com>,
Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: "mtosatti@redhat.com" <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: RE: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
Date: Mon, 27 Sep 2010 18:01:27 +0800 [thread overview]
Message-ID: <BC00F5384FCFC9499AF06F92E8B78A9E1A90718200@shsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <4CA068C7.3020004@redhat.com>
Avi Kivity wrote:
> On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote:
>> (2010/09/02 17:57), Avi Kivity wrote:
>>> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>>>> The following patch
>>>>
>>>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>>>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with
>>>> enabled LAPIC's
>>>>
>>>> ignored the fact that kvm_irq_delivery_to_apic() was also used by
>>>> ia64.
>>>>
>>>> We define kvm_lapic_enabled() to fix a compile error caused by
>>>> this. This will have the same effect as reverting the problematic
>>>> patch
>>>> for ia64.
>>>
>>> Applied, thanks.
>>>
>>
>> Hi,
>>
>> Isn't this a candidate for 2.6.36?
>>
>> Though ia64 kvm is in experimental stage and may not be working now,
>> compile errors may be bad for other people who just want to compile
>> ia64 linux.
>>
>
> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>
> It has been "experimental" for quite a while.
>
> --
> error compiling committee.c: too many arguments to function
Avi Kivity wrote:
> On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote:
>> (2010/09/02 17:57), Avi Kivity wrote:
>>> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>>>> The following patch
>>>>
>>>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>>>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with
>>>> enabled LAPIC's
>>>>
>>>> ignored the fact that kvm_irq_delivery_to_apic() was also used by
>>>> ia64.
>>>>
>>>> We define kvm_lapic_enabled() to fix a compile error caused by
>>>> this. This will have the same effect as reverting the problematic
>>>> patch
>>>> for ia64.
>>>
>>> Applied, thanks.
>>>
>>
>> Hi,
>>
>> Isn't this a candidate for 2.6.36?
>>
>> Though ia64 kvm is in experimental stage and may not be working now,
>> compile errors may be bad for other people who just want to compile
>> ia64 linux.
>>
>
> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>
> It has been "experimental" for quite a while.
I don't think the kvm/ia64 is broken in the upstream Linux, and it should work according to our last try. The big issue is about userspace support. Latest qemu maybe not work with latest kernel, but if you choose an old qemu, it should work!
Xiantao
> --
> error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-27 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 8:55 [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error Takuya Yoshikawa
2010-09-02 8:57 ` Avi Kivity
2010-09-27 6:51 ` Takuya Yoshikawa
2010-09-27 9:49 ` Avi Kivity
2010-09-27 9:52 ` Alexander Graf
2010-09-27 10:01 ` Zhang, Xiantao [this message]
2010-09-27 10:31 ` Takuya Yoshikawa
2010-09-28 9:27 ` Avi Kivity
2010-09-29 14:10 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC00F5384FCFC9499AF06F92E8B78A9E1A90718200@shsmsx502.ccr.corp.intel.com \
--to=xiantao.zhang@intel.com \
--cc=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).