RE: [PATCH v1 14/18] vfio/mdev: Add mdev available instance checking to the core

From: "Tian, Kevin" <kevin.tian@intel.com>
To: Eric Farman <farman@linux.ibm.com>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	Christoph Hellwig <hch@lst.de>, Neo Jia <cjia@nvidia.com>,
	Dheeraj Nigam <dnigam@nvidia.com>,
	Tarun Gupta <targupta@nvidia.com>
Subject: RE: [PATCH v1 14/18] vfio/mdev: Add mdev available instance checking to the core
Date: Fri, 10 Jun 2022 07:43:46 +0000	[thread overview]
Message-ID: <BN9PR11MB5276228F26CC7B9EBE13489B8CA69@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c818e1ef24c466a3b1d14d4ab10163d5e349a3b4.camel@linux.ibm.com>

> From: Eric Farman <farman@linux.ibm.com>
> Sent: Tuesday, June 7, 2022 4:24 AM
> 
> On Tue, 2022-06-07 at 01:32 +0530, Kirti Wankhede wrote:
> >
> > On 6/2/2022 10:49 PM, Eric Farman wrote:
> > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > @@ -106,6 +106,7 @@ structure to represent a mediated device's
> > > driver::
> > >   	     int  (*probe)  (struct mdev_device *dev);
> > >   	     void (*remove) (struct mdev_device *dev);
> > >   	     struct device_driver    driver;
> > > +	     unsigned int (*get_available)(struct mdev_type *mtype);
> > >        };
> > >
> >
> > This patch conflicts with Christoph Hellwig's patch. I see
> > 'supported_type_groups' is not is above structure, I beleive that
> > your
> > patch is applied on top of Christoph's patch series.
> >
> > but then in below part of code, 'add_mdev_supported_type' has also
> > being
> > removed in Christoph's patch. So this patch would not get applied
> > cleanly.
> 
> Apologies. This series was fit to 5.18 as the merge window progressed.
> Both this patch and the previous one have to adjust to the removal of
> mdev_parent_ops that came about from
> 
> commit 6b42f491e17ce13f5ff7f2d1f49c73a0f4c47b20
> Author: Jason Gunthorpe <jgg@ziepe.ca>
> Date:   Mon Apr 11 16:14:01 2022 +0200
> 
>     vfio/mdev: Remove mdev_parent_ops
> 
> I have this rebased for v2.
> 

btw with those latest changes [1] we don't need .get_available() then,
as mdev type is now added by mdev driver one-by-one then the
available instance can be provided directly in that path.

[1] https://lore.kernel.org/all/20220607055653.GA8848@lst.de/T/#m82caa423d728bce0729b8c9e8d8aff76250ec9ac