From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Yang, Lixiao" <lixiao.yang@intel.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Nicolin Chen <nicolinc@nvidia.com>,
"Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH v6 10/19] iommufd: Allow a hwpt to be aborted after allocation
Date: Fri, 21 Apr 2023 07:29:24 +0000 [thread overview]
Message-ID: <BN9PR11MB52767CDBB5A3E2D8D62E1D478C609@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <10-v6-fdb604df649a+369-iommufd_alloc_jgg@nvidia.com>
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Friday, April 21, 2023 2:51 AM
>
> During creation the hwpt must have the ioas->mutex held until the object
> is finalized. This means we need to be able to call
> iommufd_object_abort_and_destroy() while holding the mutex.
>
> Since iommufd_hw_pagetable_destroy() also needs the mutex this is
> problematic.
>
> Fix it by creating a special abort op for the object that can assume the
> caller is holding the lock, as required by the contract.
>
> The next patch will add another iommufd_object_abort_and_destroy() for a
> hwpt.
>
> Fixes: e8d57210035b ("iommufd: Add kAPI toward external drivers for
> physical devices")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
next prev parent reply other threads:[~2023-04-21 7:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 18:51 [PATCH v6 00/19] Add iommufd physical device operations for replace and alloc hwpt Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 01/19] iommufd: Move isolated msi enforcement to iommufd_device_bind() Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 02/19] iommufd: Add iommufd_group Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 03/19] iommufd: Replace the hwpt->devices list with iommufd_group Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 04/19] iommu: Export iommu_get_resv_regions() Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 05/19] iommufd: Keep track of each device's reserved regions instead of groups Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 06/19] iommufd: Use the iommufd_group to avoid duplicate MSI setup Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 07/19] iommufd: Make sw_msi_start a group global Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 08/19] iommufd: Move putting a hwpt to a helper function Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 09/19] iommufd: Add enforced_cache_coherency to iommufd_hw_pagetable_alloc() Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 10/19] iommufd: Allow a hwpt to be aborted after allocation Jason Gunthorpe
2023-04-21 7:29 ` Tian, Kevin [this message]
2023-04-20 18:51 ` [PATCH v6 11/19] iommufd: Fix locking around hwpt allocation Jason Gunthorpe
2023-04-21 7:30 ` Tian, Kevin
2023-04-20 18:51 ` [PATCH v6 12/19] iommufd: Reorganize iommufd_device_attach into iommufd_device_change_pt Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 13/19] iommu: Introduce a new iommu_group_replace_domain() API Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 14/19] iommufd: Add iommufd_device_replace() Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 15/19] iommufd: Make destroy_rwsem use a lock class per object type Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 16/19] iommufd/selftest: Test iommufd_device_replace() Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 17/19] iommufd: Add IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 18/19] iommufd/selftest: Return the real idev id from selftest mock_domain Jason Gunthorpe
2023-04-20 18:51 ` [PATCH v6 19/19] iommufd/selftest: Add a selftest for IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-04-21 1:35 ` [PATCH v6 00/19] Add iommufd physical device operations for replace and alloc hwpt Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB52767CDBB5A3E2D8D62E1D478C609@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lixiao.yang@intel.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).