From: "Tian, Kevin" <kevin.tian@intel.com>
To: Borislav Petkov <bp@alien8.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Zeng, Guang" <guang.zeng@intel.com>,
"Liu, Jing2" <jing2.liu@intel.com>, "Christopherson,,
Sean" <seanjc@google.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Wang, Wei W" <wei.w.wang@intel.com>,
"Zhong, Yang" <yang.zhong@intel.com>
Subject: RE: [PATCH v6 05/21] x86/fpu: Make XFD initialization in __fpstate_reset() a function argument
Date: Mon, 10 Jan 2022 05:15:44 +0000 [thread overview]
Message-ID: <BN9PR11MB527688406C0BDCF093C718858C509@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YdiX5y4KxQ7GY7xn@zn.tnic>
> From: Borislav Petkov <bp@alien8.de>
> Sent: Saturday, January 8, 2022 3:44 AM
>
> On Fri, Jan 07, 2022 at 01:54:56PM -0500, Paolo Bonzini wrote:
> > From: Jing Liu <jing2.liu@intel.com>
> >
> > vCPU threads are different from native tasks regarding to the initial XFD
> > value. While all native tasks follow a fixed value (init_fpstate::xfd)
> > established by the FPU core at boot, vCPU threads need to obey the reset
> > value (i.e. ZERO) defined by the specification, to meet the expectation of
> > the guest.
> >
> > Let the caller supply an argument and adjust the host and guest related
> > invocations accordingly.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> If Jing is author, then tglx's SOB should come after Jing's to mean,
> tglx handled it further.
>
> As it is now, it looks wrong.
Thanks for pointing it out! Actually this is one area which we didn't get
a clear answer from 'submitting-patches.rst' and now possibly a good
chance to get it clarified.
This patch was handled in an interesting way due to Jing's two absences:
Internal version: Jing was the original author
Signed-off-by: Jing Liu <jing2.liu@intel.com>
--- Jing's first absence ---
v1: Yang was the submitter:
Signed-off-by: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Thomas updated it in his personal branch when reviewing v1:
From: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
--- Jing was back ---
v2-v3: Jing was the submitter:
The open here is whether Jing should change the SoB order:
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Jing Liu <jing2.liu@intel.com>
or just append her name again:
Signed-off-by: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Jing Liu <jing2.liu@intel.com>
The former was selected for this patch.
--- Jing's 2nd absence ---
v4-v5: Yang was the submitter.
SoB order was partially changed (for Yang's SoB) but forgot to make Jing's
SoB as the first. It should be:
From: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
If the rule is that SoB order should not be changed, then it will be:
From: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Jing Liu <jing2.liu@intel.com>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
>
> Ditto for patches 10, 11, 12, 13.
>
> Also, I wonder if all those Signed-off-by's do mean "handled" or
> Co-developed-by but I haven't tracked that particular pile so...
>
> > Signed-off-by: Jing Liu <jing2.liu@intel.com>
> > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > Message-Id: <20220105123532.12586-6-yang.zhong@intel.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-01-10 5:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 18:54 [PATCH v6 00/21] AMX support for KVM Paolo Bonzini
2022-01-07 18:54 ` [PATCH v6 01/21] x86/fpu: Extend fpu_xstate_prctl() with guest permissions Paolo Bonzini
2022-01-07 18:54 ` [PATCH v6 02/21] x86/fpu: Prepare guest FPU for dynamically enabled FPU features Paolo Bonzini
2022-01-07 18:54 ` [PATCH v6 03/21] kvm: x86: Fix xstate_required_size() to follow XSTATE alignment rule Paolo Bonzini
2022-01-07 18:54 ` [PATCH v6 04/21] kvm: x86: Exclude unpermitted xfeatures at KVM_GET_SUPPORTED_CPUID Paolo Bonzini
2022-01-23 6:22 ` Like Xu
2022-01-24 7:18 ` Tian, Kevin
2022-01-07 18:54 ` [PATCH v6 05/21] x86/fpu: Make XFD initialization in __fpstate_reset() a function argument Paolo Bonzini
2022-01-07 19:43 ` Borislav Petkov
2022-01-10 5:15 ` Tian, Kevin [this message]
2022-01-10 8:52 ` Borislav Petkov
2022-01-10 14:18 ` Paolo Bonzini
2022-01-10 15:25 ` Borislav Petkov
2022-01-10 15:55 ` Paolo Bonzini
2022-01-10 18:18 ` Borislav Petkov
2022-01-11 1:45 ` Tian, Kevin
2022-01-07 18:54 ` [PATCH v6 06/21] x86/fpu: Add guest support to xfd_enable_feature() Paolo Bonzini
2022-01-07 18:54 ` [PATCH v6 07/21] x86/fpu: Provide fpu_enable_guest_xfd_features() for KVM Paolo Bonzini
2022-01-10 5:25 ` Tian, Kevin
2022-01-07 18:54 ` [PATCH v6 08/21] kvm: x86: Enable dynamic xfeatures at KVM_SET_CPUID2 Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 09/21] x86/fpu: Provide fpu_update_guest_xfd() for IA32_XFD emulation Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 10/21] kvm: x86: Add emulation for IA32_XFD Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 11/21] x86/fpu: Prepare xfd_err in struct fpu_guest Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 12/21] kvm: x86: Intercept #NM for saving IA32_XFD_ERR Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 13/21] kvm: x86: Emulate IA32_XFD_ERR for guest Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 14/21] kvm: x86: Disable RDMSR interception of IA32_XFD_ERR Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 15/21] kvm: x86: Add XCR0 support for Intel AMX Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 16/21] kvm: x86: Add CPUID " Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 17/21] x86/fpu: Add uabi_size to guest_fpu Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 18/21] kvm: x86: Add support for getting/setting expanded xstate buffer Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 19/21] kvm: selftests: Add support for KVM_CAP_XSAVE2 Paolo Bonzini
2022-01-17 16:51 ` Janis Schoetterl-Glausch
2022-01-18 2:06 ` Wang, Wei W
2022-01-07 18:55 ` [PATCH v6 20/21] x86/fpu: Provide fpu_sync_guest_vmexit_xfd_state() Paolo Bonzini
2022-01-07 18:55 ` [PATCH v6 21/21] kvm: x86: Disable interception for IA32_XFD on demand Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB527688406C0BDCF093C718858C509@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=bp@alien8.de \
--cc=guang.zeng@intel.com \
--cc=jing2.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=wei.w.wang@intel.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).