From: Liran Alon <liran.alon@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
max@m00nbsd.net, Joao Martins <joao.m.martins@oracle.com>,
rkrcmar@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
Date: Mon, 15 Jul 2019 21:30:48 +0300 [thread overview]
Message-ID: <C000BFA0-5FE2-4AD4-B3F5-079AFE3005A2@oracle.com> (raw)
In-Reply-To: <801988b0-b5c0-011e-5775-cb9e22f5d5c2@redhat.com>
> On 15 Jul 2019, at 21:28, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 15/07/19 19:21, Sean Christopherson wrote:
>>>> + if ((seg_reg != VCPU_SREG_FS) && (seg_reg != VCPU_SREG_GS))
>> I'm pretty sure the internal parantheses are unnecessary.
>>
>
> Indeed, that's so Pascal! :) I'll apply Vitaly's suggestion and queue it.
>
> Paolo
I like parentheses as it makes ordering of expression a no-brainer. But that’s just a matter of taste I guess.
I don’t mind you will change it according to given suggestions. :)
-Liran
next prev parent reply other threads:[~2019-07-15 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 15:47 [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS Liran Alon
2019-07-15 16:22 ` Vitaly Kuznetsov
2019-07-15 17:21 ` Sean Christopherson
2019-07-15 18:28 ` Paolo Bonzini
2019-07-15 18:30 ` Liran Alon [this message]
2019-07-15 18:44 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C000BFA0-5FE2-4AD4-B3F5-079AFE3005A2@oracle.com \
--to=liran.alon@oracle.com \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=max@m00nbsd.net \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).