kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm list <kvm@vger.kernel.org>,
	lkft-triage@lists.linaro.org,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>,
	karl.heubaum@oracle.com
Subject: Re: [kvm-unit-tests PATCH] x86: fix syntax error
Date: Tue, 18 Jun 2019 07:26:21 +0530	[thread overview]
Message-ID: <CA+G9fYswbSvf_G3nEugMy6AEOU+97A1uo1SHq=FzX0TGQ22-Og@mail.gmail.com> (raw)
In-Reply-To: <01B902DE-6191-4FF2-A51B-F7E1AA87E87C@gmail.com>

On Tue, 18 Jun 2019 at 01:09, Nadav Amit <nadav.amit@gmail.com> wrote:
>
> > On Jun 13, 2019, at 8:06 AM, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > This patch fixes this build error,
> > kvm-unit-tests/lib/x86/processor.h:497:45: error: expected ‘)’ before ‘;’ token
> >  return !!((cpuid(0x80000001).d & (1 << 20));
> >           ~                                 ^
> >
>
> Fixes: ddbb68a60534b ("kvm-unit-test: x86: Add a wrapper to check if the CPU supports NX bit in MSR_EFER")
> Cc: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Cc: Karl Heubaum <karl.heubaum@oracle.com>
>
>
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > ---
> > lib/x86/processor.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/x86/processor.h b/lib/x86/processor.h
> > index 0a65808..823d65d 100644
> > --- a/lib/x86/processor.h
> > +++ b/lib/x86/processor.h
> > @@ -494,7 +494,7 @@ static inline int has_spec_ctrl(void)
> >
> > static inline int cpu_has_efer_nx(void)
> > {
> > -     return !!((cpuid(0x80000001).d & (1 << 20));
> > +     return !!((cpuid(0x80000001).d & (1 << 20)));
>
> Just because I also encountered this issue: why would you add another
> bracket instead of removing one?

I see two !! and thought that we might need ((
Sorry if that does not make sense.

- Naresh


>
>

      reply	other threads:[~2019-06-18  1:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 15:06 [kvm-unit-tests PATCH] x86: fix syntax error Naresh Kamboju
2019-06-17 19:39 ` Nadav Amit
2019-06-18  1:56   ` Naresh Kamboju [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+G9fYswbSvf_G3nEugMy6AEOU+97A1uo1SHq=FzX0TGQ22-Og@mail.gmail.com' \
    --to=naresh.kamboju@linaro.org \
    --cc=karl.heubaum@oracle.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=nadav.amit@gmail.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).