From: Venkatesh Srinivas <venkateshs@chromium.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: mst@redhat.com, kvm@vger.kernel.org, jasowang@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/1] virtio-net: don't allocate control_buf if not supported
Date: Mon, 3 May 2021 10:30:15 -0700 [thread overview]
Message-ID: <CAA0tLEoT2P05cb8N+PXx7PLUgzvWqDtZ9eaMVhYtM5KXKF6E=A@mail.gmail.com> (raw)
In-Reply-To: <20210502093319.61313-1-mgurtovoy@nvidia.com>
On 5/2/21, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
> Not all virtio_net devices support the ctrl queue feature. Thus, there
> is no need to allocate unused resources.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Venkatesh Srinivas <venkateshs@chromium.org>
> ---
> drivers/net/virtio_net.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 7fda2ae4c40f..9b6a4a875c55 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2870,9 +2870,13 @@ static int virtnet_alloc_queues(struct virtnet_info
> *vi)
> {
> int i;
>
> - vi->ctrl = kzalloc(sizeof(*vi->ctrl), GFP_KERNEL);
> - if (!vi->ctrl)
> - goto err_ctrl;
> + if (vi->has_cvq) {
> + vi->ctrl = kzalloc(sizeof(*vi->ctrl), GFP_KERNEL);
> + if (!vi->ctrl)
> + goto err_ctrl;
> + } else {
> + vi->ctrl = NULL;
> + }
> vi->sq = kcalloc(vi->max_queue_pairs, sizeof(*vi->sq), GFP_KERNEL);
> if (!vi->sq)
> goto err_sq;
> --
> 2.18.1
>
>
next prev parent reply other threads:[~2021-05-03 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 9:33 [PATCH 1/1] virtio-net: don't allocate control_buf if not supported Max Gurtovoy
2021-05-03 17:30 ` Venkatesh Srinivas [this message]
2021-05-04 9:05 ` Pankaj Gupta
2021-05-06 2:22 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA0tLEoT2P05cb8N+PXx7PLUgzvWqDtZ9eaMVhYtM5KXKF6E=A@mail.gmail.com' \
--to=venkateshs@chromium.org \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).