From: Aaron Lewis <aaronlewis@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <graf@amazon.com>
Cc: Peter Shier <pshier@google.com>,
Jim Mattson <jmattson@google.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] selftests: kvm: Test MSR exiting to userspace
Date: Thu, 3 Dec 2020 13:47:45 -0800 [thread overview]
Message-ID: <CAAAPnDHkZaPZP6ht3y1A5mXkP=T6mDppy-zygKje1Hs5s8huWw@mail.gmail.com> (raw)
In-Reply-To: <71f1c9c0-b92c-76f9-0878-e3b8b184b7f0@redhat.com>
On Thu, Dec 3, 2020 at 9:48 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 02/12/20 16:31, Aaron Lewis wrote:
> > On Mon, Nov 9, 2020 at 9:09 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >>
> >> On 09/11/20 17:58, Aaron Lewis wrote:
> >>>> Signed-off-by: Aaron Lewis<aaronlewis@google.com>
> >>>> Reviewed-by: Alexander Graf<graf@amazon.com>
> >>>> ---
> >>>> tools/testing/selftests/kvm/.gitignore | 1 +
> >>>> tools/testing/selftests/kvm/Makefile | 1 +
> >>>> tools/testing/selftests/kvm/lib/kvm_util.c | 2 +
> >>>> .../kvm/x86_64/userspace_msr_exit_test.c | 560 ++++++++++++++++++
> >>>> 4 files changed, 564 insertions(+)
> >>>> create mode 100644 tools/testing/selftests/kvm/x86_64/userspace_msr_exit_test.c
> >>>>
> >>> It looks like the rest of this patchset has been accepted upstream.
> >>> Is this one okay to be taken too?
> >>>
> >>
> >> I needed more time to understand the overlap between the tests, but yes.
> >>
> >> Paolo
> >>
> >
> > Pinging this thread.
> >
> > Just wanted to check if this will be upstreamed soon or if there are
> > any questions about it.
>
> Yes, I'm queuing it. Any objections to replacing x86_64/user_msr_test.c
> completely, since this test is effectively a superset?
>
> Paolo
>
Hi Paolo,
The main difference between the two tests is my test does not exercise
the KVM_MSR_FILTER_DEFAULT_DENY flag. If Alex is okay with that test
being replaced I'm okay with it. However, I wouldn't be opposed to
adding it from user_msr_test.c into mine. That way they are all in
one place.
Cheers,
Aaron
next prev parent reply other threads:[~2020-12-03 21:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 19:47 [PATCH v3 0/4] Test MSR exits to userspace Aaron Lewis
2020-10-12 19:47 ` [PATCH v3 1/4] selftests: kvm: Fix the segment descriptor layout to match the actual layout Aaron Lewis
2020-10-12 19:47 ` [PATCH v3 2/4] selftests: kvm: Clear uc so UCALL_NONE is being properly reported Aaron Lewis
2020-10-12 19:47 ` [PATCH v3 3/4] selftests: kvm: Add exception handling to selftests Aaron Lewis
2020-10-13 7:42 ` Alexander Graf
2020-10-12 19:47 ` [PATCH v3 4/4] selftests: kvm: Test MSR exiting to userspace Aaron Lewis
2020-11-09 16:58 ` Aaron Lewis
2020-11-09 17:09 ` Paolo Bonzini
2020-12-02 15:31 ` Aaron Lewis
2020-12-03 17:48 ` Paolo Bonzini
2020-12-03 21:47 ` Aaron Lewis [this message]
2020-12-03 22:05 ` Alexander Graf
2020-12-03 22:12 ` Aaron Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAAPnDHkZaPZP6ht3y1A5mXkP=T6mDppy-zygKje1Hs5s8huWw@mail.gmail.com' \
--to=aaronlewis@google.com \
--cc=graf@amazon.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).