From: Jing Zhang <jingzhangos@google.com>
To: KVM <kvm@vger.kernel.org>, KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Linuxkselftest <linux-kselftest@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
David Rientjes <rientjes@google.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>
Subject: Re: [PATCH v4 0/4] KVM statistics data fd-based binary interface
Date: Mon, 10 May 2021 13:57:33 -0500 [thread overview]
Message-ID: <CAAdAUtgW0vYmr5rqiMJKbZSjgEtLQqxfHd8H0fxrTbE0o4zmWw@mail.gmail.com> (raw)
In-Reply-To: <20210429203740.1935629-1-jingzhangos@google.com>
Hi Paolo,
On Thu, Apr 29, 2021 at 3:37 PM Jing Zhang <jingzhangos@google.com> wrote:
>
> This patchset provides a file descriptor for every VM and VCPU to read
> KVM statistics data in binary format.
> It is meant to provide a lightweight, flexible, scalable and efficient
> lock-free solution for user space telemetry applications to pull the
> statistics data periodically for large scale systems. The pulling
> frequency could be as high as a few times per second.
> In this patchset, every statistics data are treated to have some
> attributes as below:
> * architecture dependent or common
> * VM statistics data or VCPU statistics data
> * type: cumulative, instantaneous,
> * unit: none for simple counter, nanosecond, microsecond,
> millisecond, second, Byte, KiByte, MiByte, GiByte. Clock Cycles
> Since no lock/synchronization is used, the consistency between all
> the statistics data is not guaranteed. That means not all statistics
> data are read out at the exact same time, since the statistics date
> are still being updated by KVM subsystems while they are read out.
>
> ---
>
> * v3 -> v4
> - Rebase to kvm/queue, commit 9f242010c3b4 ("KVM: avoid "deadlock"
> between install_new_memslots and MMU notifier")
> - Use C-stype comments in the whole patch
> - Fix wrong count for x86 VCPU stats descriptors
> - Fix KVM stats data size counting and validity check in selftest
>
> * v2 -> v3
> - Rebase to kvm/queue, commit edf408f5257b ("KVM: avoid "deadlock"
> between install_new_memslots and MMU notifier")
> - Resolve some nitpicks about format
>
> * v1 -> v2
> - Use ARRAY_SIZE to count the number of stats descriptors
> - Fix missing `size` field initialization in macro STATS_DESC
>
> [1] https://lore.kernel.org/kvm/20210402224359.2297157-1-jingzhangos@google.com
> [2] https://lore.kernel.org/kvm/20210415151741.1607806-1-jingzhangos@google.com
> [3] https://lore.kernel.org/kvm/20210423181727.596466-1-jingzhangos@google.com
>
> ---
>
> Jing Zhang (4):
> KVM: stats: Separate common stats from architecture specific ones
> KVM: stats: Add fd-based API to read binary stats data
> KVM: stats: Add documentation for statistics data binary interface
> KVM: selftests: Add selftest for KVM statistics data binary interface
>
> Documentation/virt/kvm/api.rst | 171 ++++++++
> arch/arm64/include/asm/kvm_host.h | 9 +-
> arch/arm64/kvm/guest.c | 42 +-
> arch/mips/include/asm/kvm_host.h | 9 +-
> arch/mips/kvm/mips.c | 67 ++-
> arch/powerpc/include/asm/kvm_host.h | 9 +-
> arch/powerpc/kvm/book3s.c | 68 +++-
> arch/powerpc/kvm/book3s_hv.c | 12 +-
> arch/powerpc/kvm/book3s_pr.c | 2 +-
> arch/powerpc/kvm/book3s_pr_papr.c | 2 +-
> arch/powerpc/kvm/booke.c | 63 ++-
> arch/s390/include/asm/kvm_host.h | 9 +-
> arch/s390/kvm/kvm-s390.c | 133 +++++-
> arch/x86/include/asm/kvm_host.h | 9 +-
> arch/x86/kvm/x86.c | 71 +++-
> include/linux/kvm_host.h | 132 +++++-
> include/linux/kvm_types.h | 12 +
> include/uapi/linux/kvm.h | 50 +++
> tools/testing/selftests/kvm/.gitignore | 1 +
> tools/testing/selftests/kvm/Makefile | 3 +
> .../testing/selftests/kvm/include/kvm_util.h | 3 +
> .../selftests/kvm/kvm_bin_form_stats.c | 380 ++++++++++++++++++
> tools/testing/selftests/kvm/lib/kvm_util.c | 11 +
> virt/kvm/kvm_main.c | 237 ++++++++++-
> 24 files changed, 1415 insertions(+), 90 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/kvm_bin_form_stats.c
>
>
> base-commit: 9f242010c3b46e63bc62f08fff42cef992d3801b
> --
> 2.31.1.527.g47e6f16901-goog
>
Do I need to send another version for this?
Thanks,
Jing
next prev parent reply other threads:[~2021-05-10 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 20:37 [PATCH v4 0/4] KVM statistics data fd-based binary interface Jing Zhang
2021-04-29 20:37 ` [PATCH v4 1/4] KVM: stats: Separate common stats from architecture specific ones Jing Zhang
2021-04-30 12:07 ` Marc Zyngier
2021-04-30 15:34 ` Jing Zhang
2021-04-29 20:37 ` [PATCH v4 2/4] KVM: stats: Add fd-based API to read binary stats data Jing Zhang
2021-04-30 1:26 ` kernel test robot
2021-04-30 2:26 ` Jing Zhang
2021-04-29 20:37 ` [PATCH v4 3/4] KVM: stats: Add documentation for statistics data binary interface Jing Zhang
2021-04-29 20:37 ` [PATCH v4 4/4] KVM: selftests: Add selftest for KVM " Jing Zhang
2021-05-10 18:57 ` Jing Zhang [this message]
2021-05-11 8:38 ` [PATCH v4 0/4] KVM statistics data fd-based " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdAUtgW0vYmr5rqiMJKbZSjgEtLQqxfHd8H0fxrTbE0o4zmWw@mail.gmail.com \
--to=jingzhangos@google.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=eesposit@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tsbogend@alpha.franken.de \
--cc=vkuznets@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).