From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FE2C433B4 for ; Mon, 19 Apr 2021 13:30:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2462B611CE for ; Mon, 19 Apr 2021 13:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241125AbhDSNaw (ORCPT ); Mon, 19 Apr 2021 09:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242020AbhDSN2F (ORCPT ); Mon, 19 Apr 2021 09:28:05 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05BF1C061361 for ; Mon, 19 Apr 2021 06:26:23 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id n138so56045055lfa.3 for ; Mon, 19 Apr 2021 06:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NqBtQukzUcKGvmZ1aJArxdkZjllZ69uT8+WTmwdJ6G4=; b=em/J+S9hHzBCCI9MSW7xxROUGoj1ECCpWbKbkDd7uZveF8DcpPGfSfeXe7udqDYAGS Jj37aD7VWJOTXi/3DhMCYdi9pJNW7jm5Sf4PAqzlM+s1im59ujQ9g0r3tX6QKiCnqI8I oO5sYxp5JVgxN3n4uVwCg7nst4zKPgyNiqk71xh9fzEU1SJZSiHV0spwlLta2FppoNXt 4Sn69HhmbhTj4I1GZVCwzi8/H+Q2tBi5gcCNkX4caIusJ3tMJ1W1hCmiVohKi/6R3p1P P4SE3XIUdcjPLBQZiKpeMRryN/1muaULpqJ4vS3LQj+EtgGFUJ9LyQpWIyR+n0cbkMPO AGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NqBtQukzUcKGvmZ1aJArxdkZjllZ69uT8+WTmwdJ6G4=; b=GUnNIUi4Sk9C9M/gvYRaNbtQl1nkjvgb8ieu73KPK4Q40TBFT71LXoQYtnrJNvkZ4n dsLQ6Fhuw/Ga7xaAZvoXD4t1PeAHiGKCsGLm72pEeBxqh0/TqNmz1AjTW0uQzPmqpKAi ZN4bTbuB84CEmxoZQSerZjpteJMLxpdvVCDqiXaQxuj8jluMEYbYXKyatesquuLwwgL5 Mz2ywnLTC7g1x01j1kJlU1q0YLjfS/Lx0kxcscViALOaWFn5kM3AkniVRBM7xoCSRWbv 6SYBNb0uSg2AqoaUlu2JUQdRYuiUz5sXAcayuipvVdvxoM+AxULczhA3UWTTtoiEfniu NQLA== X-Gm-Message-State: AOAM5317/St0d8Mt+nr8LQtwTaxgBtn6itVkLjRNP4sAOVpQWzFIunOf h/C3sAbTBUCWtxOoHUwO02cjRbi/ieS8dju7Eymhkg== X-Google-Smtp-Source: ABdhPJzC7C637Xaczt8wN5cywlsLikI7xQQerJcl2++bY+AQeL59litpEy9MDacIxAURgyTiZJG8O4odjR7fc14+zi0= X-Received: by 2002:a19:3813:: with SMTP id f19mr5725327lfa.473.1618838781799; Mon, 19 Apr 2021 06:26:21 -0700 (PDT) MIME-Version: 1.0 References: <20210415151741.1607806-1-jingzhangos@google.com> <20210415151741.1607806-5-jingzhangos@google.com> <9f2a8873-c2c2-ec84-58b4-7c90c59d1d25@redhat.com> In-Reply-To: <9f2a8873-c2c2-ec84-58b4-7c90c59d1d25@redhat.com> From: Jing Zhang Date: Mon, 19 Apr 2021 08:26:09 -0500 Message-ID: Subject: Re: [PATCH v2 4/4] KVM: selftests: Add selftest for KVM statistics data binary interface To: Emanuele Giuseppe Esposito Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Paolo Bonzini , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Emanuele, On Mon, Apr 19, 2021 at 6:18 AM Emanuele Giuseppe Esposito wrote: > > Hi Jing, > > > +int vm_stats_test(struct kvm_vm *vm) > > +{ > > + ssize_t ret; > > + int i, stats_fd, err = -1; > > + size_t size_desc, size_data = 0; > > + struct kvm_stats_header header; > > + struct kvm_stats_desc *stats_desc, *pdesc; > > + struct kvm_vm_stats_data *stats_data; > > + > > + // Get fd for VM stats > > Another small nitpick: comments should go in /* */ format Thanks. Will fix all comments. > > Thank you, > Emanuele > Jing