From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC0CBC48BDF for ; Thu, 10 Jun 2021 22:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6743613CA for ; Thu, 10 Jun 2021 22:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbhFJWuw (ORCPT ); Thu, 10 Jun 2021 18:50:52 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:34377 "EHLO mail-lf1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJWuw (ORCPT ); Thu, 10 Jun 2021 18:50:52 -0400 Received: by mail-lf1-f47.google.com with SMTP id f30so5690518lfj.1 for ; Thu, 10 Jun 2021 15:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NB6oruf2NY8GhkThmLRjR9OK5AwQwpQtqUKMMQIim6Q=; b=RlAcwFqFOmgURmrxCa/W36B7QDS48JsLtq3ukyvETwbEWY9n6kYR15OJLR1+m/Ayoa IFOPgRn+MWHaHRxfzFfw8YKkIIgs2ZCGs14vP+ZHoxKKjXRv9KyIxggliDfqvjBIjYCq V94EObt9JIV8pROJEKleOqvY3Lp4pDZx/7FjYYuWinqlm2/1Nytb+dPDD+hsW55nAX2C NGH7VQWOTOBEWWcYPh7P7p/+0rXPvWK0nt69u5R3R8eLlCTBAmYqdMr2C3ARulRpzg4R 8Q+QNXpBn09jeaY6tlsnVHADHx9NQbdhTP8oD+yYICZdPO5DY7zVDUU7MeMZbXvDgcyf zO/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NB6oruf2NY8GhkThmLRjR9OK5AwQwpQtqUKMMQIim6Q=; b=XmglZDyztSZWQfy456ZiZm3MpE6xWZk5WXzAWlBLgi675Z+wI5hGCPZIBiP2ri/mXx EisbzIEf542i1caL8LL14IxqRfD3GU2nWGVKVJtV30yB9F9wvutJCdkF7zMKJU9AuPdz dY+hLdEkvMdmDDlhzpfR9lG9tNRd9qadpdLstaKgUpPqHHMnrsOamg8gfqFZbYW09k2L X/a2GL32g8K4OnY1P3WCxaBqLwpVGUKpP20kBmLamJ9aAPF8U3kJH2zZBSIdk9gf+oBA GOL9tEkZ0ubZ6z2AjYXESAl41dt0kb3ZBVPdpqw1slrd1BsRoH33PiG5q52yJBXB5Jtc Fhhw== X-Gm-Message-State: AOAM530UUvvpzMMJGlae59fqk4+GdyNMM0WrR/c7l63+9Z3M13vHx+8a Blgosv1YF0tUUzjYlL2udNnJYvmr07wBAzfh1O+Fo+TyqjcolA== X-Google-Smtp-Source: ABdhPJwpq8QDGCaA9l+lT37FAjCpuN+L2RrV3HuGV2JBb0AyojuY/TbuPJ2PuprqJ9F9pWJFYjBYz3jwM7wdjjpecmI= X-Received: by 2002:a05:6512:39ca:: with SMTP id k10mr657852lfu.473.1623365274281; Thu, 10 Jun 2021 15:47:54 -0700 (PDT) MIME-Version: 1.0 References: <20210603211426.790093-1-jingzhangos@google.com> <20210603211426.790093-3-jingzhangos@google.com> In-Reply-To: From: Jing Zhang Date: Thu, 10 Jun 2021 17:47:41 -0500 Message-ID: Subject: Re: [PATCH v7 2/4] KVM: stats: Add fd-based API to read binary stats data To: Paolo Bonzini Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Paolo, On Thu, Jun 10, 2021 at 11:23 AM Paolo Bonzini wrote: > > On 03/06/21 23:14, Jing Zhang wrote: > > +#define DEFINE_VM_STATS_DESC(...) { \ > > + STATS_DESC_COUNTER("remote_tlb_flush"), \ > > + ## __VA_ARGS__ \ > > +} > > + > > +#define DEFINE_VCPU_STATS_DESC(...) { \ > > + STATS_DESC_COUNTER("halt_successful_poll"), \ > > + STATS_DESC_COUNTER("halt_attempted_poll"), \ > > + STATS_DESC_COUNTER("halt_poll_invalid"), \ > > + STATS_DESC_COUNTER("halt_wakeup"), \ > > + STATS_DESC_TIME_NSEC("halt_poll_success_ns"), \ > > + STATS_DESC_TIME_NSEC("halt_poll_fail_ns"), \ > > + ## __VA_ARGS__ \ > > Let's instead put this (note it's without braces) in macros like these > > #define KVM_GENERIC_VM_STATS() \ > STATS_DESC_COUNTER("remote_tlb_flush"), > > #define KVM_GENERIC_VCPU_STATS(...) \ > STATS_DESC_COUNTER("halt_successful_poll"), \ > STATS_DESC_COUNTER("halt_attempted_poll"), \ > STATS_DESC_COUNTER("halt_poll_invalid"), \ > STATS_DESC_COUNTER("halt_wakeup"), \ > STATS_DESC_TIME_NSEC("halt_poll_success_ns"), \ > STATS_DESC_TIME_NSEC("halt_poll_fail_ns"), > > and it can be used in the arch files. In fact it can even be added in patch 1 and > switched to STATS_DESC_* here. > > Paolo > I just remember that the reason I used braces is due to following error from checkpatch.pl: ERROR: Macros with complex values should be enclosed in parentheses So, just keep it as it is? Thanks, Jing