From: Anup Patel <anup@brainfault.org>
To: Andrew Jones <drjones@redhat.com>
Cc: Anup Patel <Anup.Patel@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Paolo Bonzini <pbonzini@redhat.com>, Radim K <rkrcmar@redhat.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Christoph Hellwig <hch@infradead.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 10/21] RISC-V: KVM: Handle MMIO exits for VCPU
Date: Tue, 3 Sep 2019 14:56:29 +0530 [thread overview]
Message-ID: <CAAhSdy1p3KG-m_Gw4LzeY+ap3reVpx+FNjugnDJEDj_-jhgc2w@mail.gmail.com> (raw)
In-Reply-To: <20190903085823.s4amn27pewc54hl2@kamzik.brq.redhat.com>
On Tue, Sep 3, 2019 at 2:28 PM Andrew Jones <drjones@redhat.com> wrote:
>
> On Thu, Aug 29, 2019 at 01:56:18PM +0000, Anup Patel wrote:
> > int kvm_riscv_vcpu_mmio_return(struct kvm_vcpu *vcpu, struct kvm_run *run)
> > {
> > - /* TODO: */
> > + u8 data8;
> > + u16 data16;
> > + u32 data32;
> > + u64 data64;
> > + ulong insn;
> > + int len, shift;
> > +
> > + insn = vcpu->arch.mmio_decode.insn;
> > +
> > + if (run->mmio.is_write)
> > + goto done;
> > +
> > + len = vcpu->arch.mmio_decode.len;
> > + shift = vcpu->arch.mmio_decode.shift;
> > +
> > + switch (len) {
> > + case 1:
> > + data8 = *((u8 *)run->mmio.data);
> > + SET_RD(insn, &vcpu->arch.guest_context,
> > + (ulong)data8 << shift >> shift);
> > + break;
> > + case 2:
> > + data16 = *((u16 *)run->mmio.data);
> > + SET_RD(insn, &vcpu->arch.guest_context,
> > + (ulong)data16 << shift >> shift);
> > + break;
> > + case 4:
> > + data32 = *((u32 *)run->mmio.data);
> > + SET_RD(insn, &vcpu->arch.guest_context,
> > + (ulong)data32 << shift >> shift);
> > + break;
> > + case 8:
> > + data64 = *((u64 *)run->mmio.data);
> > + SET_RD(insn, &vcpu->arch.guest_context,
> > + (ulong)data64 << shift >> shift);
> > + break;
> > + default:
> > + return -ENOTSUPP;
> > + };
> > +
> > +done:
> > + /* Move to next instruction */
> > + vcpu->arch.guest_context.sepc += INSN_LEN(insn);
> > +
>
> As I pointed out in the last review, just moving this instruction skip
> here is not enough. Doing so introduces the same problem that 2113c5f62b74
> ("KVM: arm/arm64: Only skip MMIO insn once") fixes for arm.
Thanks Drew, I had seen your comment previously but forgot
to address it in v6. I will address it in v7.
Regards,
Anup
next prev parent reply other threads:[~2019-09-03 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 13:55 [PATCH v6 00/21] KVM RISC-V Support Anup Patel
2019-08-29 13:55 ` [PATCH v6 01/21] KVM: RISC-V: Add KVM_REG_RISCV for ONE_REG interface Anup Patel
2019-08-29 13:55 ` [PATCH v6 02/21] RISC-V: Add bitmap reprensenting ISA features common across CPUs Anup Patel
2019-08-29 13:55 ` [PATCH v6 03/21] RISC-V: Export few kernel symbols Anup Patel
2019-08-29 13:55 ` [PATCH v6 04/21] RISC-V: Add hypervisor extension related CSR defines Anup Patel
2019-08-29 13:55 ` [PATCH v6 05/21] RISC-V: Add initial skeletal KVM support Anup Patel
2019-08-29 13:55 ` [PATCH v6 06/21] RISC-V: KVM: Implement VCPU create, init and destroy functions Anup Patel
2019-08-29 13:55 ` [PATCH v6 07/21] RISC-V: KVM: Implement VCPU interrupts and requests handling Anup Patel
2019-08-29 13:56 ` [PATCH v6 08/21] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls Anup Patel
2019-08-29 13:56 ` [PATCH v6 09/21] RISC-V: KVM: Implement VCPU world-switch Anup Patel
2019-08-29 13:56 ` [PATCH v6 10/21] RISC-V: KVM: Handle MMIO exits for VCPU Anup Patel
2019-09-03 8:58 ` Andrew Jones
2019-09-03 9:26 ` Anup Patel [this message]
2019-09-03 9:33 ` Anup Patel
2019-08-29 13:56 ` [PATCH v6 11/21] RISC-V: KVM: Handle WFI " Anup Patel
2019-08-29 13:56 ` [PATCH v6 12/21] RISC-V: KVM: Implement VMID allocator Anup Patel
2019-08-29 13:56 ` [PATCH v6 13/21] RISC-V: KVM: Implement stage2 page table programming Anup Patel
2019-08-29 13:56 ` [PATCH v6 14/21] RISC-V: KVM: Implement MMU notifiers Anup Patel
2019-08-29 13:56 ` [PATCH v6 15/21] RISC-V: KVM: Add timer functionality Anup Patel
2019-08-29 13:56 ` [PATCH v6 16/21] RISC-V: KVM: FP lazy save/restore Anup Patel
2019-08-29 13:57 ` [PATCH v6 17/21] RISC-V: KVM: Implement ONE REG interface for FP registers Anup Patel
2019-08-29 13:57 ` [PATCH v6 18/21] RISC-V: KVM: Add SBI v0.1 support Anup Patel
2019-08-29 13:57 ` [PATCH v6 19/21] RISC-V: KVM: Document RISC-V specific parts of KVM API Anup Patel
2019-09-03 9:53 ` Anup Patel
2019-08-29 13:57 ` [PATCH v6 20/21] RISC-V: Enable VIRTIO drivers in RV64 and RV32 defconfig Anup Patel
2019-08-29 13:57 ` [PATCH v6 21/21] RISC-V: KVM: Add MAINTAINERS entry Anup Patel
2019-09-04 3:39 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy1p3KG-m_Gw4LzeY+ap3reVpx+FNjugnDJEDj_-jhgc2w@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=drjones@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).