From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A20C433EF for ; Thu, 28 Oct 2021 15:37:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE524610C7 for ; Thu, 28 Oct 2021 15:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbhJ1PkN (ORCPT ); Thu, 28 Oct 2021 11:40:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbhJ1PkM (ORCPT ); Thu, 28 Oct 2021 11:40:12 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23C02C061745 for ; Thu, 28 Oct 2021 08:37:45 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id d10so11014183wrb.1 for ; Thu, 28 Oct 2021 08:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ajUUMnRMo/CfkqSYpjRKHF3O4uKdRUUoW9jGXm2YH/8=; b=YClg6r+Pjz+KcVotJsLNPXbLH9rBZDDotsVtGKPz45+pVaqV/8VvUjjmgxfln+tl16 pNgJZteb1XcKJu8Rq2O+Ynz/a0nrl5R1VzAZCyQkBuj48jBJeEKmI91ATjk19ed3/slS C81BjQjFI0TIdMvGA8/1Np3r5VYzz1pIj+AiN8B5R5bQdSRzJ6eV67fmV1J/W1Ph864s bkD9r359wt5zBv00KUKa4W7rGTHW5SHb/bNIWtzdO8UdH441eq4XJD3GsByeCoLO5L8I ZMgcjyA79pYnH7Dabb/EbzZdbWJ8S5Kjtru5/7Zsbabr+kgD909eP4gs8/bUlW2SdT/L ns2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ajUUMnRMo/CfkqSYpjRKHF3O4uKdRUUoW9jGXm2YH/8=; b=tcqCEG1HD2G2Gcuhm1HOrDSJiksX9O4zOOyh7EGtViq8jDG6uARwzetGgnAqvTWwVS 3eUeYa5Sho4TIKoEFqJFg1KF5zVJrpkSxhdy+vt58FoDVMceNeUWBEIRf3VHX6tgZtmJ Db4WqbLiJWqQPATINPWzsAhJsvFETgGh5r63DhZsEkovkJENu1caK/xW6W+1LU/b2wBg 329ru1AKRVcLsTviLDBn5Oy1oIkA835PRfHswgc5xx0fb3Qo+CGK5DpS1pbRygb+fGhZ 09acBlCG5Yu1OFPKAVoX3VG+5EgEKhIXlS1yL1XacqMZQ1OBkstXUGymX1+yVzScCwzp 564A== X-Gm-Message-State: AOAM531XBJVsad5GDu/QEDz4+7zi7wX+r3zfQG/lHHTFF2jQFvVTbdRb a5QtinR4qLR1GAXoDwq1RLisBfUTOoKpfejkUmeLWw== X-Google-Smtp-Source: ABdhPJxSMxsPRNAYx8kcStvSGAzhyUcPtRJdvcLJU2SSsUAIOtS/6o5e+daLbr1h08HtBnOjMLBDhmaly+ryMxoJScw= X-Received: by 2002:a05:6000:1a89:: with SMTP id f9mr6700138wry.249.1635435463471; Thu, 28 Oct 2021 08:37:43 -0700 (PDT) MIME-Version: 1.0 References: <20211026170136.2147619-2-anup.patel@wdc.com> In-Reply-To: From: Anup Patel Date: Thu, 28 Oct 2021 21:07:31 +0530 Message-ID: Subject: Re: [PATCH 1/3] RISC-V: Enable KVM in RV64 and RV32 defconfigs as a module To: Palmer Dabbelt Cc: Anup Patel , Paul Walmsley , Albert Ou , Paolo Bonzini , Atish Patra , KVM General , kvm-riscv@lists.infradead.org, linux-riscv , "linux-kernel@vger.kernel.org List" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Oct 28, 2021 at 3:42 AM Palmer Dabbelt wrote: > > On Tue, 26 Oct 2021 10:01:34 PDT (-0700), Anup Patel wrote: > > Let's enable KVM RISC-V in RV64 and RV32 defconfigs as module > > so that it always built along with the default kernel image. > > Turning on KVM in the defconfigs seems like the right way to go, but > this has more diff than just that. Not sure if that's all just > savedefconfig stuff, I usually try and split out the non-functional > changes from anything that makes a change. Other diffs in the defconfigs are generated by "make savedefconfig". I guess this is because most people don't use "make savedefconfig" to generate updated defconfigs. > > If you checked then > > Acked-by: Palmer Dabbelt > > assuming you want to keep these together. LMK if you want me to take > this on its own (I'll split it up if you do). Thanks Palmer. Regards, Anup > > > > > Signed-off-by: Anup Patel > > --- > > arch/riscv/configs/defconfig | 15 +++++++-------- > > arch/riscv/configs/rv32_defconfig | 8 ++++---- > > 2 files changed, 11 insertions(+), 12 deletions(-) > > > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > > index 4ebc80315f01..40506dfab5cf 100644 > > --- a/arch/riscv/configs/defconfig > > +++ b/arch/riscv/configs/defconfig > > @@ -2,6 +2,7 @@ CONFIG_SYSVIPC=y > > CONFIG_POSIX_MQUEUE=y > > CONFIG_NO_HZ_IDLE=y > > CONFIG_HIGH_RES_TIMERS=y > > +CONFIG_BPF_SYSCALL=y > > CONFIG_IKCONFIG=y > > CONFIG_IKCONFIG_PROC=y > > CONFIG_CGROUPS=y > > @@ -13,12 +14,14 @@ CONFIG_USER_NS=y > > CONFIG_CHECKPOINT_RESTORE=y > > CONFIG_BLK_DEV_INITRD=y > > CONFIG_EXPERT=y > > -CONFIG_BPF_SYSCALL=y > > +# CONFIG_SYSFS_SYSCALL is not set > > +CONFIG_SOC_MICROCHIP_POLARFIRE=y > > CONFIG_SOC_SIFIVE=y > > CONFIG_SOC_VIRT=y > > -CONFIG_SOC_MICROCHIP_POLARFIRE=y > > CONFIG_SMP=y > > CONFIG_HOTPLUG_CPU=y > > +CONFIG_VIRTUALIZATION=y > > +CONFIG_KVM=m > > CONFIG_JUMP_LABEL=y > > CONFIG_MODULES=y > > CONFIG_MODULE_UNLOAD=y > > @@ -68,14 +71,12 @@ CONFIG_HW_RANDOM=y > > CONFIG_HW_RANDOM_VIRTIO=y > > CONFIG_SPI=y > > CONFIG_SPI_SIFIVE=y > > +# CONFIG_PTP_1588_CLOCK is not set > > CONFIG_GPIOLIB=y > > CONFIG_GPIO_SIFIVE=y > > -# CONFIG_PTP_1588_CLOCK is not set > > -CONFIG_POWER_RESET=y > > CONFIG_DRM=y > > CONFIG_DRM_RADEON=y > > CONFIG_DRM_VIRTIO_GPU=y > > -CONFIG_FRAMEBUFFER_CONSOLE=y > > CONFIG_USB=y > > CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_XHCI_PLATFORM=y > > @@ -85,10 +86,10 @@ CONFIG_USB_OHCI_HCD=y > > CONFIG_USB_OHCI_HCD_PLATFORM=y > > CONFIG_USB_STORAGE=y > > CONFIG_USB_UAS=y > > +CONFIG_MMC=y > > CONFIG_MMC_SDHCI=y > > CONFIG_MMC_SDHCI_PLTFM=y > > CONFIG_MMC_SDHCI_CADENCE=y > > -CONFIG_MMC=y > > CONFIG_MMC_SPI=y > > CONFIG_RTC_CLASS=y > > CONFIG_VIRTIO_PCI=y > > @@ -139,5 +140,3 @@ CONFIG_RCU_EQS_DEBUG=y > > # CONFIG_FTRACE is not set > > # CONFIG_RUNTIME_TESTING_MENU is not set > > CONFIG_MEMTEST=y > > -# CONFIG_SYSFS_SYSCALL is not set > > -CONFIG_EFI=y > > diff --git a/arch/riscv/configs/rv32_defconfig b/arch/riscv/configs/rv32_defconfig > > index 434ef5b64599..44022e048efd 100644 > > --- a/arch/riscv/configs/rv32_defconfig > > +++ b/arch/riscv/configs/rv32_defconfig > > @@ -2,6 +2,7 @@ CONFIG_SYSVIPC=y > > CONFIG_POSIX_MQUEUE=y > > CONFIG_NO_HZ_IDLE=y > > CONFIG_HIGH_RES_TIMERS=y > > +CONFIG_BPF_SYSCALL=y > > CONFIG_IKCONFIG=y > > CONFIG_IKCONFIG_PROC=y > > CONFIG_CGROUPS=y > > @@ -13,12 +14,14 @@ CONFIG_USER_NS=y > > CONFIG_CHECKPOINT_RESTORE=y > > CONFIG_BLK_DEV_INITRD=y > > CONFIG_EXPERT=y > > -CONFIG_BPF_SYSCALL=y > > +# CONFIG_SYSFS_SYSCALL is not set > > CONFIG_SOC_SIFIVE=y > > CONFIG_SOC_VIRT=y > > CONFIG_ARCH_RV32I=y > > CONFIG_SMP=y > > CONFIG_HOTPLUG_CPU=y > > +CONFIG_VIRTUALIZATION=y > > +CONFIG_KVM=m > > CONFIG_JUMP_LABEL=y > > CONFIG_MODULES=y > > CONFIG_MODULE_UNLOAD=y > > @@ -67,11 +70,9 @@ CONFIG_HW_RANDOM_VIRTIO=y > > CONFIG_SPI=y > > CONFIG_SPI_SIFIVE=y > > # CONFIG_PTP_1588_CLOCK is not set > > -CONFIG_POWER_RESET=y > > CONFIG_DRM=y > > CONFIG_DRM_RADEON=y > > CONFIG_DRM_VIRTIO_GPU=y > > -CONFIG_FRAMEBUFFER_CONSOLE=y > > CONFIG_USB=y > > CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_XHCI_PLATFORM=y > > @@ -130,4 +131,3 @@ CONFIG_RCU_EQS_DEBUG=y > > # CONFIG_FTRACE is not set > > # CONFIG_RUNTIME_TESTING_MENU is not set > > CONFIG_MEMTEST=y > > -# CONFIG_SYSFS_SYSCALL is not set