From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF1EDC433FF for ; Tue, 30 Jul 2019 11:04:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B589C2089E for ; Tue, 30 Jul 2019 11:04:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="rtURJ5tj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730070AbfG3LEJ (ORCPT ); Tue, 30 Jul 2019 07:04:09 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54017 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfG3LEJ (ORCPT ); Tue, 30 Jul 2019 07:04:09 -0400 Received: by mail-wm1-f65.google.com with SMTP id x15so56738802wmj.3 for ; Tue, 30 Jul 2019 04:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kAaSPn1SAnhMdouNiZFncd+kh2nGtT7o+fO0/xriDJM=; b=rtURJ5tjTGQezYchXptus1tZePK5IushptflcrP+I4zOEDOzawXa8lEWlpLTyABP05 WcvP42levCh9WFweBkXwjLV1O5gjaYCtAwo+LxmXtdams5440uB9Au+0IOqlvgvCQDox 0QOqGc7cZaSYRFIthov7WGk9xFRrfQ0yCDdK0rjX6zdeViKjkIRWrKXe9a22hTtEjF5w KGjWactDJtFahKEJAaqTgK/W8UYIa3JZ9O0X+MmpSKu+T2/MtMpStwlLkpTtXNhqkvZn rOUJC9iwH8FJ0XRoZsS1uEXPEwUTIwGTrq2+SSYaj9QV4vsq0oNdAjo25MqtWEk3+RUF 80Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kAaSPn1SAnhMdouNiZFncd+kh2nGtT7o+fO0/xriDJM=; b=PKpVEZuhMWWLoSSdSGjZu5n0qjSBKBcu081dIxrY4DZ5z52uk21hgtXXj5iqoqRH1u P46kglIunQJjDf3IAlSOt38RrnFNqylcICOboRh/mR3BD0WPXLDNa8x8RL7sX0ULu//x 6zjX8rzM2g7Gvp09bU8udCjbWqmm8HJVKjiS09Rn8ClbwmKg+yId9JRfYBbJ4w9S13ru mbfRdFkdzbh3fQ5u2g3naqT/IEOIeQbwp+ey4uD5entGze1PtVZ8ia1k0X45nqdsZWrr o27PiBhY88ONcSlNWIRb6Qo/cYCvn1GPrI/ybKxHgnXIAimFXJxjwdwbHzVzYECUkpuG vS2w== X-Gm-Message-State: APjAAAWXmieXgRQoHzh2C9Nim04+DYUlk5Z3V6G0tLqcpFCRYNKsKH2t wlvw7HB22LCKaskMdTWPuNYjAAlW7PQoHvEkb5Q= X-Google-Smtp-Source: APXvYqyCdoUNtlHs7orkEBhS8EG9A8IbKL4dk2VepkFVzYAN9ZWH2nTWL3pZtJ3WiTvF6eb5BbRHk5ldhvDUkb7rXyU= X-Received: by 2002:a05:600c:254b:: with SMTP id e11mr97733084wma.171.1564484646738; Tue, 30 Jul 2019 04:04:06 -0700 (PDT) MIME-Version: 1.0 References: <20190729115544.17895-1-anup.patel@wdc.com> <20190729115544.17895-4-anup.patel@wdc.com> In-Reply-To: From: Anup Patel Date: Tue, 30 Jul 2019 16:33:55 +0530 Message-ID: Subject: Re: [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support To: Paolo Bonzini Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Radim K , Daniel Lezcano , Thomas Gleixner , Atish Patra , Alistair Francis , Damien Le Moal , Christoph Hellwig , "kvm@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jul 30, 2019 at 2:55 PM Paolo Bonzini wrote: > > On 29/07/19 13:56, Anup Patel wrote: > > +void kvm_riscv_halt_guest(struct kvm *kvm) > > +{ > > + int i; > > + struct kvm_vcpu *vcpu; > > + > > + kvm_for_each_vcpu(i, vcpu, kvm) > > + vcpu->arch.pause = true; > > + kvm_make_all_cpus_request(kvm, KVM_REQ_SLEEP); > > +} > > + > > +void kvm_riscv_resume_guest(struct kvm *kvm) > > +{ > > + int i; > > + struct kvm_vcpu *vcpu; > > + > > + kvm_for_each_vcpu(i, vcpu, kvm) { > > + vcpu->arch.pause = false; > > + swake_up_one(kvm_arch_vcpu_wq(vcpu)); > > + } > > Are these unused? (Perhaps I'm just blind :)) Not used as of now. The intention was to have APIs for freezing/unfreezing Guest which can be used to do some work which is atomic from Guest perspective. I will remove it and add it back when required. Regards, Anup